t4733: quality-feedback-helper.sh: add --include-positive flag to scan-merged

[marcusquinn]

Summary

• Adds --include-positive flag to scan-merged to override the positive-review filter for debugging
• When passed, bypasses both the summary-only bot filter (0 inline comments + COMMENTED state) and the approval-only body filter (LGTM, no further comments, etc.)
• Adds 7 new tests covering the flag behaviour and the Gemini-style positive confirmation pattern from the issue

Changes

quality-feedback-helper.sh

• cmd_scan_merged: parse --include-positive flag, pass to _scan_single_pr
• _scan_single_pr: accept $4 include_positive param; pass as --argjson to both jq filters; $summary_only and $approval_only filters are bypassed when true
• Help text and usage comment updated with --include-positive docs and example

tests/test-quality-feedback-main-verification.sh

• _test_approval_filter: accepts $4 include_positive param
• New _test_summary_only_filter helper for testing the bot summary-only filter
• 7 new test cases for GH#4733 (all pass)

Test results

26/26 passed, 0 failed

Acceptance criteria

• scan-merged does not generate issues for reviews with 0 inline comments and positive-only body text (already implemented; tests confirm)
• Existing actionable reviews (with inline comments or negative language) still generate issues (existing 19 tests pass)
• Add a --include-positive flag to override the filter for debugging

Closes #4733

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 02c7d412-b912-4fe4-9093-ce810d040d5f

📥 Commits

Reviewing files that changed from the base of the PR and between 5538747 and c5601d1.

📒 Files selected for processing (2)

• .agents/scripts/quality-feedback-helper.sh
• .agents/scripts/tests/test-quality-feedback-main-verification.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/t4733-quality-feedback-filter-positive

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[alex-solovyev]

Merge conflict detected after base branch updates. Worker for issue #4733 needs to rebase this branch before merge.

[alex-solovyev]

Closing: superseded by PR #4748 which was just merged. Both PRs addressed the same issue (#4733 — add --include-positive flag to quality-feedback-helper.sh scan-merged). PR #4742 was also CONFLICTING.