Skip to content

t3522: chore(version-manager): extract badge patterns into local variables #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 14, 2026
Merged

t3522: chore(version-manager): extract badge patterns into local variables #4735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .agents/scripts/version-manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,13 +774,15 @@ update_version_in_files() {
fi

# Update README version badge (skip if using dynamic GitHub release badge)
local dynamic_badge_pattern="img.shields.io/github/v/release"
local hardcoded_badge_pattern="Version-[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*-blue"
if [[ -f "$REPO_ROOT/README.md" ]]; then
if grep -q "img.shields.io/github/v/release" "$REPO_ROOT/README.md"; then
if grep -q "$dynamic_badge_pattern" "$REPO_ROOT/README.md"; then
# Dynamic badge - no update needed, GitHub handles it automatically
print_success "README.md uses dynamic GitHub release badge (no update needed)" >&2
elif grep -q "Version-[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*-blue" "$REPO_ROOT/README.md"; then
elif grep -q "$hardcoded_badge_pattern" "$REPO_ROOT/README.md"; then
# Hardcoded badge - update it
sed_inplace "s/Version-[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*-blue/Version-$new_version-blue/" "$REPO_ROOT/README.md"
sed_inplace "s/$hardcoded_badge_pattern/Version-$new_version-blue/" "$REPO_ROOT/README.md"

# Validate the update was successful
if grep -q "Version-$new_version-blue" "$REPO_ROOT/README.md"; then
Expand Down
Loading