Skip to content

t3576: address PR #281 maintainability feedback #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 14, 2026
Merged

t3576: address PR #281 maintainability feedback #4722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions .agents/scripts/generate-opencode-agents.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,32 @@ EAGER_MCPS = set()
# Lazy-loaded (enabled: False): Subagent-only, start on-demand
# sentry/socket: Remote MCPs requiring auth, disable until configured
# These save ~7K+ tokens on session startup
LAZY_MCPS = {'claude-code-mcp', 'outscraper', 'dataforseo', 'shadcn', 'macos-automator',
'gsc', 'localwp', 'chrome-devtools', 'quickfile', 'amazon-order-history',
'google-analytics-mcp', 'MCP_DOCKER', 'ahrefs',
'playwriter', 'augment-context-engine', 'context7',
'sentry', 'socket', 'ios-simulator',
'openapi-search',
# Oh-My-OpenCode MCPs - disable globally, use @github-search/@context7 subagents
'grep_app', 'websearch', 'gh_grep'}
LAZY_MCPS = {
'MCP_DOCKER',
'ahrefs',
'amazon-order-history',
'augment-context-engine',
'chrome-devtools',
'claude-code-mcp',
'context7',
'dataforseo',
'gh_grep',
'google-analytics-mcp',
# Oh-My-OpenCode MCPs - disable globally, use @github-search/@context7 subagents
'grep_app',
'gsc',
'ios-simulator',
'localwp',
'macos-automator',
'openapi-search',
'outscraper',
'playwriter',
'quickfile',
'sentry',
'shadcn',
'socket',
'websearch',
}
Comment on lines +549 to +574
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While alphabetizing the list is a good improvement for scannability, it has unintentionally separated the Oh-My-OpenCode MCPs (gh_grep, grep_app, websearch) from their explanatory comment. This makes it harder to understand which MCPs the comment applies to.

To improve maintainability, I suggest grouping these related MCPs together with their comment at the end of the set. This preserves the logical grouping, which is more important for long-term maintenance than strict alphabetical order across the entire set.

LAZY_MCPS = {
    'MCP_DOCKER',
    'ahrefs',
    'amazon-order-history',
    'augment-context-engine',
    'chrome-devtools',
    'claude-code-mcp',
    'context7',
    'dataforseo',
    'google-analytics-mcp',
    'gsc',
    'ios-simulator',
    'localwp',
    'macos-automator',
    'openapi-search',
    'outscraper',
    'playwriter',
    'quickfile',
    'sentry',
    'shadcn',
    'socket',

    # Oh-My-OpenCode MCPs - disable globally, use @github-search/@context7 subagents
    'gh_grep',
    'grep_app',
    'websearch',
}

# Note: gh_grep removed from aidevops but may exist from old configs or OmO

# Apply loading policy to existing MCPs and warn about uncategorized ones
Expand Down
Loading