Skip to content

t3668: simplify gh repo view URL in Phase 13 — remove unnecessary sed#4646

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/t3668-pulse-phase13-sed-simplify
Mar 14, 2026
Merged

t3668: simplify gh repo view URL in Phase 13 — remove unnecessary sed#4646
marcusquinn merged 1 commit intomainfrom
bugfix/t3668-pulse-phase13-sed-simplify

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

Summary

  • Removes the complex sed extraction used to parse owner/repo from a git remote URL in Phase 13 of supervisor-archived/pulse.sh
  • The gh CLI accepts full remote URLs directly via -R, making the sed pipeline redundant
  • Passing the raw git remote get-url origin output is more robust (handles SSH, HTTPS, .git suffix variants) and more readable

Change

-  viewer_permission=$(gh repo view --json viewerPermission --jq '.viewerPermission' \
-    -R "$(git -C "$skill_update_repo_root" remote get-url origin 2>/dev/null |
-      sed 's|.*github\.com[:/]\([^/]*/[^/]*\)\.git|\1|; s|.*github\.com[:/]\([^/]*/[^/]*\)$|\1|')" \
-    2>/dev/null || echo "")
+  viewer_permission=$(gh repo view --json viewerPermission --jq '.viewerPermission' \
+    -R "$(git -C "$skill_update_repo_root" remote get-url origin 2>/dev/null)" \
+    2>/dev/null || echo "")

Verification

Tested gh repo view -R "https://github.com/marcusquinn/aidevops.git" --json viewerPermission --jq '.viewerPermission' — returns ADMIN correctly with a full git URL.

Closes #3668

…xtraction

The gh CLI accepts full remote URLs directly via -R, making the sed-based
owner/repo extraction redundant. Passing the raw git remote URL is more
robust (handles SSH, HTTPS, .git suffix variants) and more readable.

Addresses Gemini medium review feedback from PR #1610.
Closes #3668
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c74af0b-a928-488c-9013-c11f50728aff

📥 Commits

Reviewing files that changed from the base of the PR and between e8117b7 and f14523a.

📒 Files selected for processing (1)
  • .agents/scripts/supervisor-archived/pulse.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t3668-pulse-phase13-sed-simplify
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 413 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sat Mar 14 06:14:01 UTC 2026: Code review monitoring started
Sat Mar 14 06:14:02 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 413

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 413
  • VULNERABILITIES: 0

Generated on: Sat Mar 14 06:14:05 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link
Copy Markdown

@marcusquinn marcusquinn merged commit 4ca353a into main Mar 14, 2026
17 checks passed
@marcusquinn marcusquinn deleted the bugfix/t3668-pulse-phase13-sed-simplify branch March 14, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: PR #1610 review feedback (medium)

1 participant