t3316: fix validatePositionalParams — add pipe-delimited cell exclusion#4614
Conversation
…sitionalParams Address Gemini review feedback from PR #2388: add $[1-9]\s*\| pattern to skip pipe-delimited table cells where $N appears before a pipe character. The existing check only caught rows starting with | (markdown table rows); this adds coverage for cells like 'echo "$5 | next column"'. Closes #3316
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Mar 14 05:33:13 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
2 participants
Summary
$[1-9]\s*\|pattern to the false-positive exclusion block invalidatePositionalParams(), covering pipe-delimited table cells where$Nappears before a|character (e.g.echo "$5 | next column")^\s*\|check only caught markdown table rows that start with|; this adds coverage for cells where$Nprecedes a pipe mid-lineFindings addressed
ifstatements — the suggestion also included the missing$[1-9]\s*\|pattern; that pattern is the actionable fix (theifblocks were already consolidated in the prior PR)07b8c65(line-wide escaped-dollar skip replaced with strip-then-check approach); no further change neededCloses #3316