Skip to content

t3696: resolve gemini review feedback on auto-verify logic in todo-sync.sh #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 14, 2026
Merged

t3696: resolve gemini review feedback on auto-verify logic in todo-sync.sh #4605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .agents/scripts/supervisor-archived/todo-sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,19 +639,14 @@ process_verify_queue() {
local verified_count=0
local failed_count=0
local auto_verified_count=0
local max_auto_verify_per_pulse=50
local MAX_AUTO_VERIFY_PER_PULSE=50

while IFS='|' read -r tid trepo; do
[[ -z "$tid" ]] && continue

local verify_file="$trepo/todo/VERIFY.md"
local has_entry=false

if [[ -f "$verify_file" ]] && grep -q -- "^- \[ \] v[0-9]* $tid " "$verify_file" 2>/dev/null; then
has_entry=true
fi

if [[ "$has_entry" == "true" ]]; then
# Has VERIFY.md entry — run the defined checks
log_info " $tid: running verification checks"
cmd_transition "$tid" "verifying" 2>>"$SUPERVISOR_LOG" || {
Expand All @@ -672,14 +667,15 @@ process_verify_queue() {
else
# No VERIFY.md entry — auto-verify (PR merged + CI passed is sufficient)
# Rate-limit to avoid overwhelming the state machine in one pulse
if [[ "$auto_verified_count" -ge "$max_auto_verify_per_pulse" ]]; then
if [[ "$auto_verified_count" -ge "$MAX_AUTO_VERIFY_PER_PULSE" ]]; then
continue
fi
cmd_transition "$tid" "verified" 2>>"$SUPERVISOR_LOG" || {
log_warn " $tid: failed to auto-verify"
continue
}
auto_verified_count=$((auto_verified_count + 1))
log_info " $tid: auto-verified (no VERIFY.md entry)"
fi
done <<<"$deployed_tasks"

Expand Down
Loading