fix: triage PR #403 voice AI review feedback (t147.6) #458
Conversation
- Fix CPU-only auto-detect falling back to cuda (crashes on CPU hosts) Now defaults to --server mode with warning - Add docker guard to cmd_stop (consistent with cmd_docker_start/cmd_status) - Replace || exit with || return 1 in docker functions (proper set -e handling) - Replace hardcoded 192.168.1.100 with <server-ip> placeholder in help - Fix PyTorch version typo: 2.10+ -> 2.4+ (matches upstream torch>=2.4.0) - Add API key storage guidance for OpenAI API usage Already fixed in prior PRs (replied with evidence): - nltk stderr suppression (PR #447) - cmd_stop fixed sleep 2 -> polling loop (PR #447) - transcribe command docs removed (commit fd2aa84) - detect_gpu stderr no longer suppressed - shift pattern refactored to explicit if/shift - README Voice section already condensed ShellCheck: zero violations.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves various feedback points from a previous voice AI integration PR (#403). The changes focus on enhancing the robustness of the speech-to-speech helper script, improving error handling for Docker operations, and refining documentation for clarity and accuracy. The overall goal is to make the voice AI features more reliable and user-friendly by fixing identified issues and providing better guidance. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 19:09:33 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses several identified issues from the voice AI review, enhancing the robustness, correctness, and clarity of the speech-to-speech-helper.sh script and its associated documentation. Key improvements include better error handling in shell functions by replacing exit with return 1, adding a Docker availability check, and updating documentation for API key storage and PyTorch version requirements. These changes contribute to a more reliable and user-friendly experience.
|
|
||
| # Stop Docker if running | ||
| if [[ -f "${S2S_DIR}/docker-compose.yml" ]]; then | ||
| if command -v docker &>/dev/null && [[ -f "${S2S_DIR}/docker-compose.yml" ]]; then |
There was a problem hiding this comment.
Adding command -v docker &>/dev/null before attempting Docker operations significantly improves the script's robustness. This prevents errors if Docker is not installed on the system, providing a more graceful failure or alternative path. This is a good practice for dependency checks.
| if command -v docker &>/dev/null && [[ -f "${S2S_DIR}/docker-compose.yml" ]]; then | |
| if command -v docker &>/dev/null &>/dev/null && [[ -f "${S2S_DIR}/docker-compose.yml" ]]; then |
| if docker compose -f "${S2S_DIR}/docker-compose.yml" ps --quiet 2>/dev/null | grep -q .; then | ||
| print_info "Stopping Docker containers..." | ||
| (cd "$S2S_DIR" && docker compose down) || exit | ||
| (cd "$S2S_DIR" && docker compose down) || return 1 |
There was a problem hiding this comment.
Similar to the previous comment, changing || exit to || return 1 here ensures consistent and proper error handling within the function, preventing the entire script from exiting prematurely if the docker compose down command fails. This is crucial for maintaining script control flow.
| (cd "$S2S_DIR" && docker compose down) || return 1 | |
| (cd "$S2S_DIR" && docker compose down) || return 1 |
| echo " $0 start --cuda --language auto --background" | ||
| echo " $0 start --server" | ||
| echo " $0 client --host 192.168.1.100" | ||
| echo " $0 client --host <server-ip>" |
There was a problem hiding this comment.
Replacing the hardcoded IP address with a generic placeholder like <server-ip> in the help message improves the reusability and clarity of the example. This makes the documentation more adaptable and less confusing for users in different network environments.
| echo " $0 client --host <server-ip>" | |
| echo " $0 client --host <server-ip>" |
1 participant
Summary
Fixes Applied
--servermode on CPU-only hostscommand -v dockerguard<server-ip>placeholderAlready Fixed (replied with evidence)
Quality
Closes t147.6