Skip to content

fix: revert MAX_WORKERS_CAP config key to match config system#4469

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/fix-max-workers-config-key
Mar 13, 2026
Merged

fix: revert MAX_WORKERS_CAP config key to match config system#4469
marcusquinn merged 1 commit intomainfrom
bugfix/fix-max-workers-config-key

Conversation

@marcusquinn
Copy link
Owner

@marcusquinn marcusquinn commented Mar 13, 2026 •
edited by coderabbitai bot
Loading

Summary

PR #4453 changed the config_get key from orchestration.max_workers_cap to orchestration.max_concurrent_workers. This was wrong — the config system reads from config.jsonc, not settings.json, and config.jsonc uses the key max_workers_cap.

The key change caused config_get to miss the user's value (24) and fall back to the hardcoded default of 8, capping the pulse at 8 workers regardless of config.

Root cause

Two config files exist:

  • ~/.config/aidevops/settings.json — has orchestration.max_concurrent_workers (legacy)
  • ~/.config/aidevops/config.jsonc — has orchestration.max_workers_cap (authoritative, used by config_get)

PR #4453 assumed settings.json was authoritative. It's not — config_get() reads config.jsonc via _get_merged_config().

Fix

Revert the key to orchestration.max_workers_cap. The user's config.jsonc already has max_workers_cap: 24.

Summary by CodeRabbit

  • Chores
    • Updated the configuration source for determining the maximum concurrent workers limit.

@marcusquinn
fix: revert MAX_WORKERS_CAP config key to match config system
6684e84 
PR #4453 changed the config_get key from 'orchestration.max_workers_cap'
to 'orchestration.max_concurrent_workers'. But the config system reads
from config.jsonc (not settings.json), and config.jsonc uses the key
'max_workers_cap'. The key change caused config_get to miss the user's
value (24) and fall back to the hardcoded default of 8, capping the
pulse at 8 workers regardless of config.
@gemini-code-assist
Copy link

gemini-code-assist bot commented Mar 13, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@marcusquinn marcusquinn merged commit 100b635 into main Mar 13, 2026
12 of 13 checks passed
@marcusquinn marcusquinn deleted the bugfix/fix-max-workers-config-key branch March 13, 2026 22:46
@github-actions github-actions bot added the bug Auto-created from TODO.md tag label Mar 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 31f394bf-1f97-4d1c-99b5-f1289f8c1ac9

📥 Commits

Reviewing files that changed from the base of the PR and between 9a9ad9f and 6684e84.

📒 Files selected for processing (1)
  • .agents/scripts/pulse-wrapper.sh

Walkthrough

The pull request modifies .agents/scripts/pulse-wrapper.sh to update the configuration key referenced for initializing MAX_WORKERS_CAP from orchestration.max_concurrent_workers to orchestration.max_workers_cap. This is a targeted configuration parameter swap with no logic changes.

Changes

Cohort / File(s) Summary
Configuration Key Update
.agents/scripts/pulse-wrapper.sh		 Replaces the orchestration config key used for MAX_WORKERS_CAP initialization from orchestration.max_concurrent_workers to orchestration.max_workers_cap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🔧 A key swapped with surgical grace,
From max_concurrent to max_workers_cap,
One line changed, zero debt in place,
The orchestration closes the gap,
DevOps flows smooth, no collapse. ⚡

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/fix-max-workers-config-key
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 414 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Fri Mar 13 22:46:51 UTC 2026: Code review monitoring started
Fri Mar 13 22:46:52 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 414

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 414
  • VULNERABILITIES: 0

Generated on: Fri Mar 13 22:46:54 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Auto-created from TODO.md tag

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marcusquinn