t1477: align pulse issue dispatch docs with code-vs-ops routing#4450
t1477: align pulse issue dispatch docs with code-vs-ops routing#4450marcusquinn merged 2 commits intomainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughIntroduces an execution-mode selection (stage 7.5) in pulse dispatch to branch between /full-loop for code-change issues and a direct domain-command path for ops issues; centralizes dispatch prompts into a DISPATCH_PROMPT variable used across initial, lineage/subtask, and batch dispatch entry points. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Classifier
participant Dispatcher
participant HeadlessRuntime
participant Agent
User->>Classifier: submit issue
Classifier-->>Dispatcher: issue + classification
Dispatcher->>Dispatcher: evaluate execution-mode (stage 7.5)
alt Code-change (/full-loop)
Dispatcher->>HeadlessRuntime: invoke with DISPATCH_PROMPT (/full-loop)
HeadlessRuntime->>Agent: run full-loop flow
Agent-->>HeadlessRuntime: results
HeadlessRuntime-->>Dispatcher: dispatch outcome
else Ops (direct command)
Dispatcher->>HeadlessRuntime: invoke with DISPATCH_PROMPT (direct command)
HeadlessRuntime->>Agent: execute direct domain command
Agent-->>HeadlessRuntime: results
HeadlessRuntime-->>Dispatcher: dispatch outcome
end
Dispatcher-->>User: final status/response
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Mar 13 17:18:23 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.agents/scripts/commands/pulse.md (1)
614-617: Add an explicit non-emptyDISPATCH_PROMPTguard in dispatch examples.With mode-aware overrides, a failed inference can leave the prompt blank and cause dispatch failure. Add a guard/fallback in the snippets so worker launch remains deterministic.
Suggested hardening snippet
DISPATCH_PROMPT="/full-loop Implement issue #<number> (<url>) -- <brief description>" # For ops issues, replace DISPATCH_PROMPT with a direct command (no /full-loop) # Example: DISPATCH_PROMPT="/seo-export all <domain> --days 30" +[[ -n "$DISPATCH_PROMPT" ]] || DISPATCH_PROMPT="/full-loop Implement issue #<number> (<url>) -- <brief description>"Also applies to: 699-701, 756-757
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/scripts/commands/pulse.md around lines 614 - 617, Several dispatch examples set DISPATCH_PROMPT directly and can end up empty after mode-aware overrides; add an explicit non-empty guard/fallback so dispatch is deterministic. For each DISPATCH_PROMPT occurrence (the example assignment and other example blocks), ensure you either assign with a default (e.g. DISPATCH_PROMPT=${DISPATCH_PROMPT:-"/full-loop Implement issue #<number> (<url>) -- <brief description"} ) or add an immediate check like [ -n "$DISPATCH_PROMPT" ] || DISPATCH_PROMPT="..."; do the same for the ops-style examples (where the value should be a direct command, not /full-loop) so every worker launch uses a guaranteed non-empty prompt.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agents/scripts/commands/pulse.md:
- Line 616: The example DISPATCH_PROMPT uses flags (--account, --format) that
are not part of the documented /seo-export interface; update the example to use
the actual /seo-export invocation (remove the unsupported flags and use the
documented positional parameters/format token instead), e.g. change
DISPATCH_PROMPT="/seo-export --account <account> --format summary" to the
correct form matching the command signature such as DISPATCH_PROMPT="/seo-export
<account> summary" (ensure the placeholder names and order match the /seo-export
interface).
---
Nitpick comments:
In @.agents/scripts/commands/pulse.md:
- Around line 614-617: Several dispatch examples set DISPATCH_PROMPT directly
and can end up empty after mode-aware overrides; add an explicit non-empty
guard/fallback so dispatch is deterministic. For each DISPATCH_PROMPT occurrence
(the example assignment and other example blocks), ensure you either assign with
a default (e.g. DISPATCH_PROMPT=${DISPATCH_PROMPT:-"/full-loop Implement issue
#<number> (<url>) -- <brief description"} ) or add an immediate check like [ -n
"$DISPATCH_PROMPT" ] || DISPATCH_PROMPT="..."; do the same for the ops-style
examples (where the value should be a direct command, not /full-loop) so every
worker launch uses a guaranteed non-empty prompt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 31db829a-63cb-49df-986b-1778578d3c41
📒 Files selected for processing (1)
.agents/scripts/commands/pulse.md
…ort example - Add non-empty guard fallback for DISPATCH_PROMPT at all 3 dispatch sites - Fix /seo-export example to use correct positional signature (all <domain> --days 30) instead of unsupported --account/--format flags
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Mar 13 17:25:21 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
|
@coderabbitai review Addressed all feedback:
|
|
🧠 Learnings used✅ Actions performedReview triggered.
|
|
Closes #4449. Included in release v2.172.22 and deployed via setup.sh. |
marcusquinn
added
the
review-feedback-scanned
2 participants
Summary
/pulsedocs to explicitly choose dispatch mode by issue type (code-change vs operational)DISPATCH_PROMPTpattern so ops commands can run directly without/full-loopCloses #4449
Summary by CodeRabbit
Refactor
Documentation