Skip to content

fix(sonarcloud): add missing default cases to case statements #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Jan 11, 2026
Merged

fix(sonarcloud): add missing default cases to case statements #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .agent/scripts/quality-loop-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,9 @@ pr_review_loop() {
fi
fi
;;
*)
print_warning "Unknown PR status: $status"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The print_warning function is likely not available in this script's execution context. Functions defined in aidevops.sh are not automatically inherited by helper scripts that are executed in a subshell. This will likely cause a 'command not found' runtime error. To ensure robustness, it's safer to use a standard command like echo to print the warning to standard error.

Suggested change
print_warning "Unknown PR status: $status"
echo "WARNING: Unknown PR status: $status" >&2

;;
esac

iteration=$(increment_iteration)
Expand Down
6 changes: 6 additions & 0 deletions .agent/scripts/terminal-title-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ detect_terminal() {
echo "hyper"
return 0
;;
*)
# Not a known TERM_PROGRAM, continue to TERM check
;;
esac

# Check by TERM variable for other terminals
Expand All @@ -107,6 +110,9 @@ detect_terminal() {
echo "compatible"
return 0
;;
*)
# Not a known TERM, continue to other checks
;;
esac

# Check for Windows Terminal
Expand Down
Loading