fix: add trap-guarded mktemp helper in test-pr-task-check.sh#4329
fix: add trap-guarded mktemp helper in test-pr-task-check.sh#4329alex-solovyev merged 1 commit intomainfrom
Conversation
Addresses quality-debt from PR #1260 review (issue #3691). Introduces run_with_temp_todo() helper that creates a temp file, registers a trap EXIT for guaranteed cleanup, runs the test, then removes the file and clears the trap — satisfying the style-guide requirement that all mktemp calls have a trap for cleanup. All 25 test cases continue to pass; ShellCheck reports zero violations. Closes #3691
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Mar 13 02:44:49 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|



Summary
Fixes quality-debt from PR #1260 review feedback (issue #3691).
run_with_temp_todo()helper that encapsulatesmktempcreation,trap EXITregistration, test execution, and cleanup — satisfying the style-guide requirement that allmktempcalls have atrapfor cleanup (style-guide line 33)mktemp/rm -fblocks in Test Group 5 with calls to the new helperThe other three findings from the issue (
verbose()SC2015 pattern,check_pr_task_idmissingreturn 0× 2) were already fixed in a prior commit onmain.Closes #3691