marcusquinn · alex-solovyev · Mar 13, 2026 · Mar 12, 2026 · Mar 12, 2026 · gemini-code-assist
diff --git a/.agents/scripts/stats-wrapper.sh b/.agents/scripts/stats-wrapper.sh
@@ -35,6 +35,14 @@ mkdir -p "$(dirname "$STATS_PIDFILE")"
 
 #######################################
 # Portable elapsed-seconds lookup for a running PID
+#
+# Robustness notes (GH#4271 — PR #4232 review findings):
+# - Both ps probes use `|| true` so set -euo pipefail cannot abort the
+#   function before the etime fallback runs (critical finding, coderabbit).
+# - awk uses `exit 1` for all invalid-input branches (medium finding, gemini).
+#   The `|| true` on the awk command substitution is intentional — it prevents
+#   set -euo pipefail from aborting on awk parse failure; the ^[0-9]+$ guard
+#   below handles the empty-result case cleanly.
-#
-# Robustness notes (GH#4271 — PR #4232 review findings):
-# - Both ps probes use `|| true` so set -euo pipefail cannot abort the
-#   function before the etime fallback runs (critical finding, coderabbit).
-# - awk uses `exit 1` for all invalid-input branches (medium finding, gemini).
-#   The `|| true` on the awk command substitution is intentional — it prevents
-#   set -euo pipefail from aborting on awk parse failure; the ^[0-9]+$ guard
-#   below handles the empty-result case cleanly.
+# Robustness notes:
+# - The `ps` commands use `|| true` to prevent `set -euo pipefail` from
+#   aborting the script if the process disappears. This allows the `etime`
+#   fallback logic to execute.
+# - The `awk` command substitution also uses `|| true`. `awk` is scripted to
+#   `exit 1` on invalid input, and this guard prevents script termination.
+#   The subsequent `^[0-9]+$` check handles the empty output case.
-#
-# Robustness notes (GH#4271 — PR #4232 review findings):
-# - Both ps probes use `|| true` so set -euo pipefail cannot abort the
-#   function before the etime fallback runs (critical finding, coderabbit).
-# - awk uses `exit 1` for all invalid-input branches (medium finding, gemini).
-#   The `|| true` on the awk command substitution is intentional — it prevents
-#   set -euo pipefail from aborting on awk parse failure; the ^[0-9]+$ guard
-#   below handles the empty-result case cleanly.
+# Robustness notes:
+# - The `ps` commands use `|| true` to prevent `set -euo pipefail` from
+#   aborting the script if the process disappears. This allows the `etime`
+#   fallback logic to execute.
+# - The `awk` command substitution also uses `|| true`. `awk` is scripted to
+#   `exit 1` on invalid input, and this guard prevents script termination.
+#   The subsequent `^[0-9]+$` check handles the empty output case.
 #######################################
 _stats_process_elapsed_seconds() {
 	local pid="$1"