chore: clean up oh-my-opencode config on update#417
Conversation
Remove ~/.config/opencode/oh-my-opencode.json and the plugin entry from opencode.json during cleanup_deprecated_paths(), ensuring existing installs are fully cleaned on next aidevops update.
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the update process by ensuring a thorough cleanup of Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. WalkthroughThis PR adds cleanup logic to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 03:25:58 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to clean up oh-my-opencode artifacts during an update. The changes in setup.sh correctly remove the oh-my-opencode.json config file and also remove the plugin entry from opencode.json using jq. The implementation is robust, handling cases where jq is not present or the configuration file doesn't exist. I've suggested a minor improvement to make the jq command more concise and idiomatic, which enhances maintainability. Overall, the changes are well-implemented and achieve the stated goal.
| if jq -e '.plugin | index("oh-my-opencode")' "$opencode_config" >/dev/null 2>&1; then | ||
| local tmp_file | ||
| tmp_file=$(mktemp) | ||
| jq '.plugin = [.plugin[] | select(. != "oh-my-opencode")]' "$opencode_config" > "$tmp_file" && mv "$tmp_file" "$opencode_config" |
There was a problem hiding this comment.
The jq command to remove an element from the JSON array can be simplified. Using the -= operator is more concise and idiomatic for removing elements from a JSON array, which improves code readability and maintainability.
| jq '.plugin = [.plugin[] | select(. != "oh-my-opencode")]' "$opencode_config" > "$tmp_file" && mv "$tmp_file" "$opencode_config" | |
| jq '.plugin -= ["oh-my-opencode"]' "$opencode_config" > "$tmp_file" && mv "$tmp_file" "$opencode_config" |
1 participant
Summary
~/.config/opencode/oh-my-opencode.jsonconfig file on updateoh-my-opencodefrom thepluginarray inopencode.jsonon updateEnsures existing installs are fully cleaned of OmO artifacts when users run
aidevops updateorsetup.sh.Summary by CodeRabbit