Skip to content

t1436: keep pulse focused on dispatch#4131

Merged
marcusquinn merged 2 commits intomainfrom
bugfix/t1436-fix-pulse-dispatch-boundary
Mar 11, 2026
Merged

t1436: keep pulse focused on dispatch#4131
marcusquinn merged 2 commits intomainfrom
bugfix/t1436-fix-pulse-dispatch-boundary

Conversation

@marcusquinn
Copy link
Owner

@marcusquinn marcusquinn commented Mar 11, 2026

Summary

  • harden the pulse instructions so the supervisor dispatches and coordinates workers instead of drifting into direct repo implementation work
  • keep the fresh-cycle launchd model by making direct coding inside pulse explicitly out of bounds
  • preserve worker dispatch/merge behavior while reducing the chance that one pulse process holds the queue hostage

Closes #4130

Summary by CodeRabbit

  • Documentation
    • Updated supervisor documentation to clarify operational boundaries and responsibilities, detailing dispatcher workflow restrictions and coordination protocols for improved system consistency.

Clarify the supervisor boundary so pulse sessions dispatch workers and coordinate queue state instead of drifting into direct repo implementation work. This preserves the fresh-cycle launchd model and prevents one pulse process from holding the queue hostage by acting like a worker.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bbecd1b7-b830-46c3-a5f8-dfa7abd6f300

📥 Commits

Reviewing files that changed from the base of the PR and between 5e83d84 and df34302.

📒 Files selected for processing (1)
  • .agents/scripts/commands/pulse.md

Walkthrough

This PR adds a mandatory supervisor boundary section to .agents/scripts/commands/pulse.md, clarifying that the supervisor operates as a dispatcher rather than a worker. It explicitly prohibits implementing repo code changes during a pulse, restricting supervisor actions to queue inspection, coordination commands, merging, commenting, labeling, and worker dispatching via opencode run.

Changes

Cohort / File(s) Summary
Supervisor Boundary Clarification
.agents/scripts/commands/pulse.md
Added mandatory supervisor boundary section clarifying dispatcher-only role, prohibiting repo code changes during a pulse, and requiring worker dispatch via opencode run for coding tasks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

bug

Poem

📋 The pulse flows on, a dispatcher's dance,
Observe and coordinate, not code's expanse,
Queue the workers, let them run,
Supervisor guides—one step, well-done! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'keep pulse focused on dispatch' accurately captures the main change: hardening pulse instructions to ensure the supervisor remains a dispatcher rather than performing direct repository work.
Linked Issues check ✅ Passed The changes directly address issue #4130 by adding supervisor boundary documentation that enforces pulse remains a dispatcher/coordinator and prohibits direct coding, preventing monopolization of the queue.
Out of Scope Changes check ✅ Passed All changes are scoped to documenting the supervisor boundary in pulse.md, directly supporting the objective of clarifying dispatch-focused responsibilities without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t1436-fix-pulse-dispatch-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 397 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Wed Mar 11 05:18:49 UTC 2026: Code review monitoring started
Wed Mar 11 05:18:50 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 397

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 397
  • VULNERABILITIES: 0

Generated on: Wed Mar 11 05:18:52 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.agents/scripts/commands/pulse.md:
- Line 13: The "Supervisor boundary (MANDATORY)" rule conflicts with later steps
that instruct committing TODO.md and mission state changes locally; update the
document so both sections use the same model: either (A) keep the strict
no-repo-mutations rule in the "Supervisor boundary (MANDATORY)" header and
change all later steps that mention committing or editing files (e.g., the steps
that reference committing TODO.md and mission state changes) to instead dispatch
a worker via the headless helper (opencode run) for any code/worktree changes,
or (B) relax the boundary to permit supervisor-local commits and explicitly
remove the “NEVER edit files” line and add safe-local-edit guidance; ensure you
update the "Supervisor boundary (MANDATORY)" paragraph and every later reference
to committing TODO.md/mission state so they consistently follow the chosen
model.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 070dd157-6dc0-4e88-91a2-db38556e36a5

📥 Commits

Reviewing files that changed from the base of the PR and between 200a2c4 and 5e83d84.

📒 Files selected for processing (1)
  • .agents/scripts/commands/pulse.md

Keep the supervisor boundary strict for source-code implementation while explicitly allowing the coordination-file updates the pulse already owns. This removes the prompt conflict that let the supervisor drift into worker behavior without blocking TODO sync and mission state transitions.
@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 397 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Wed Mar 11 05:22:14 UTC 2026: Code review monitoring started
Wed Mar 11 05:22:14 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 397

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 397
  • VULNERABILITIES: 0

Generated on: Wed Mar 11 05:22:17 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

@marcusquinn marcusquinn merged commit 0aee364 into main Mar 11, 2026
12 checks passed
@marcusquinn marcusquinn deleted the bugfix/t1436-fix-pulse-dispatch-boundary branch March 11, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t1436: Fix pulse dispatch loop from acting as a worker

1 participant