t1435: keep pulse sessions fresh and canonical#4129
Merged
marcusquinn merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Prevent supervisor pulse runs from reusing persisted OpenCode sessions so each cycle executes against fresh pre-fetched state instead of stale conversational context. Also ensure setup keeps autonomous pulse services pinned to the canonical main repo path when deployed from a linked worktree, so auto-updated machines do not supervise feature worktrees by accident.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughFixes pulse session reuse causing dispatch stalls by preventing pulse runs from persisting or retrieving sessions. Adds session clearing for pulse role, updates worktree path resolution in setup configuration, and adds test coverage to verify pulse runs don't reuse sessions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Mar 11 05:02:55 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced Mar 12, 2026
alex-solovyev
added a commit
that referenced
this pull request
Mar 17, 2026
…alse repos PULSE_DIR defaulted to ~/Git/aidevops, causing the host app to associate all supervisor pulse sessions with that project — even when it had pulse:false in repos.json. This created 155+ orphaned sessions in ~36h. Root causes: 1. pulse-wrapper.sh hardcoded PULSE_DIR to ~/Git/aidevops (line 214) 2. setup.sh explicitly set PULSE_DIR to the aidevops repo path in both launchd plist and cron job environment variables 3. Session reuse was intentionally disabled for pulse role in PR #4129 (headless-runtime-helper.sh clears session ID each cycle to avoid stale context), so each cycle creates a fresh session — by design Fix: - Change PULSE_DIR default to ~/.aidevops/.agent-workspace/ (neutral path not associated with any managed repo) - Update setup.sh launchd plist and cron job to use the neutral path - Add mkdir -p for PULSE_DIR to ensure the directory exists - Document why session reuse is disabled (stale context prevention) The supervisor is a framework-level process, not a project-level one. Using a neutral workspace path means pulse sessions are filed under the framework workspace rather than polluting any specific project's session list. Closes #5136
alex-solovyev
added a commit
that referenced
this pull request
Mar 17, 2026
…alse repos (#5137) PULSE_DIR defaulted to ~/Git/aidevops, causing the host app to associate all supervisor pulse sessions with that project — even when it had pulse:false in repos.json. This created 155+ orphaned sessions in ~36h. Root causes: 1. pulse-wrapper.sh hardcoded PULSE_DIR to ~/Git/aidevops (line 214) 2. setup.sh explicitly set PULSE_DIR to the aidevops repo path in both launchd plist and cron job environment variables 3. Session reuse was intentionally disabled for pulse role in PR #4129 (headless-runtime-helper.sh clears session ID each cycle to avoid stale context), so each cycle creates a fresh session — by design Fix: - Change PULSE_DIR default to ~/.aidevops/.agent-workspace/ (neutral path not associated with any managed repo) - Update setup.sh launchd plist and cron job to use the neutral path - Add mkdir -p for PULSE_DIR to ensure the directory exists - Document why session reuse is disabled (stale context prevention) The supervisor is a framework-level process, not a project-level one. Using a neutral workspace path means pulse sessions are filed under the framework workspace rather than polluting any specific project's session list. Closes #5136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.shresolve the canonical main worktree forPULSE_DIRso auto-updated machines do not repoint pulse at feature worktreesCloses #4128
Summary by CodeRabbit
Bug Fixes
Tests