Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .agents/scripts/commands/pr-loop.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ The script performs these checks each iteration:
If issues are found:
- CI failures: Report and wait for fixes
- Changes requested: **Verify before acting** (see below), then address valid feedback
- Unresolved AI feedback (COMMENTED): Some bots (e.g., Gemini Code Assist) post as `COMMENTED` rather than `CHANGES_REQUESTED`, so GitHub's `reviewDecision` stays `NONE`. The loop detects unresolved review threads and surfaces this feedback for action.
- Stale review: Auto-trigger re-review (unless `--no-auto-trigger`)

### AI Bot Review Verification
Expand Down
24 changes: 20 additions & 4 deletions .agents/scripts/quality-loop-helper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -912,10 +912,26 @@ pr_review_loop() {
print_info "Address verified feedback and push updates."
;;
WAITING)
print_info "Waiting for review..."
# Check if review is stale and trigger re-review if enabled
if [[ "$auto_trigger_review" == "true" ]] && check_and_trigger_review "$pr_number"; then
print_info "Re-review triggered, waiting for response..."
# Check for unresolved AI review threads (e.g., Gemini posts as
# COMMENTED, not CHANGES_REQUESTED, so reviewDecision stays NONE
# but feedback still needs addressing)
local waiting_unresolved_result
check_unresolved_review_comments "$pr_number"
waiting_unresolved_result=$?

if [[ $waiting_unresolved_result -eq 2 ]]; then
print_warning "Could not verify AI review status (API error) - proceeding with caution"
elif [[ $waiting_unresolved_result -eq 1 ]]; then
print_warning "AI reviewers left unresolved feedback (review posted as COMMENTED, not CHANGES_REQUESTED)"
get_pr_feedback "$pr_number"
print_warning "IMPORTANT: Verify AI bot suggestions before implementing — reviewers can hallucinate. Check claims against runtime/docs first."
print_info "Address verified feedback and push updates."
else
print_info "Waiting for review..."
# Check if review is stale and trigger re-review if enabled
if [[ "$auto_trigger_review" == "true" ]] && check_and_trigger_review "$pr_number"; then
print_info "Re-review triggered, waiting for response..."
fi
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.
;;
*)
Expand Down