refactor: rename .agent/ to .agents/ for industry alignment#396
Merged
marcusquinn merged 4 commits intomainfrom Feb 6, 2026
Merged
refactor: rename .agent/ to .agents/ for industry alignment#396marcusquinn merged 4 commits intomainfrom
marcusquinn merged 4 commits intomainfrom
Conversation
The industry is converging on .agents/ folder convention (aligning with AGENTS.md). This commit renames the directory; content updates follow.
- Replace .agent/ with .agents/ in 200+ files (docs, scripts, configs) - Update setup.sh source_dir, aliases, output messages - Update aidevops.sh init to create .agents symlink with .agent migration - Update migrate_loop_state_directories() for .agents/loop-state/ - Add migrate_agent_to_agents_folder() to setup.sh for user migration - Update .gitignore, sonar-project.properties, homebrew formula - Update README.md, AGENTS.md, CONTRIBUTING.md references - Preserve intentional .agent references in migration code
Contributor
|
Important Review skippedToo many files! This PR contains 299 files, which is 149 over the limit of 150. You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 6 18:37:35 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the codebase by standardizing the directory name for AI agents from Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 6 18:43:10 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring to rename the .agent/ directory to .agents/ across the entire codebase, which is a good move for industry alignment. The changes are extensive and appear to be mostly correct. I've found a few minor issues, mainly related to the search-and-replace affecting external URLs in documentation and some inconsistencies in script paths. I've also spotted a redundant loop in one of the scripts. My feedback includes suggestions to correct these. Overall, a solid refactoring effort.
| readonly LOCK_FILE="/tmp/aidevops-${SCRIPT_NAME}.lock" | ||
| readonly TMP_DIR="$HOME/.agent/tmp" | ||
| readonly TMP_DIR="$HOME/.agents/tmp" | ||
| readonly AGENT_DIR="$HOME/.agent" |
There was a problem hiding this comment.
The variable AGENT_DIR is set to $HOME/.agent, but other paths like LOG_DIR and TMP_DIR have been updated to use $HOME/.agents. This seems inconsistent. If the intention is to clean up the new directory structure, this should be updated to $HOME/.agents.
Suggested change
| readonly AGENT_DIR="$HOME/.agent" | |
| readonly AGENT_DIR="$HOME/.agents" |
Comment on lines
+43
to
+48
| - **Coolify API**: https://coolify.io/.agents/api | ||
| - **Coolify GitHub**: https://github.com/coollabsio/coolify | ||
|
|
||
| ### Content Management | ||
|
|
||
| - **MainWP API**: https://mainwp.com/help/.agent/mainwp-rest-api/ | ||
| - **MainWP API**: https://mainwp.com/help/.agents/mainwp-rest-api/ |
There was a problem hiding this comment.
These external URLs have been modified by the search-and-replace, but the new paths like /.agents/ are likely incorrect for these domains. The original paths were probably also incorrect. Please verify and correct these URLs. For example:
https://coolify.io/.agents/apishould likely be a valid API documentation link, such ashttps://coolify.io/docs/api-reference.https://mainwp.com/help/.agents/mainwp-rest-api/should probably behttps://mainwp.com/help/mainwp-rest-api/.
This issue appears on lines 43, 48, 108, 115, 120, 148, 149, and 174 in this file.
|
|
||
| # Fix shellcheck issues in new files | ||
| for file in .agent/scripts/*.sh .agent/scripts/*.sh; do | ||
| for file in .agents/scripts/*.sh .agents/scripts/*.sh; do |
There was a problem hiding this comment.
This loop iterates over the same set of files twice, which is redundant. You can remove the duplicate part.
Suggested change
| for file in .agents/scripts/*.sh .agents/scripts/*.sh; do | |
| for file in .agents/scripts/*.sh; do |
| - Valid Vercel authentication token (for deployment commands only) | ||
|
|
||
| For more information, see the Vercel CLI documentation: https://vercel.com/.agent/cli | ||
| For more information, see the Vercel CLI documentation: https://vercel.com/.agents/cli |
There was a problem hiding this comment.
This URL was likely altered incorrectly by the search-and-replace. https://vercel.com/.agents/cli is not a valid URL. The correct URL for Vercel CLI documentation is https://vercel.com/docs/cli. The original URL was also incorrect.
Suggested change
| For more information, see the Vercel CLI documentation: https://vercel.com/.agents/cli | |
| For more information, see the Vercel CLI documentation: https://vercel.com/docs/cli |
| rm -rf "$path_to_remove/.agents/loop-state" 2>/dev/null || true | ||
| rm -rf "$path_to_remove/.agents/tmp" 2>/dev/null || true | ||
| rm -f "$path_to_remove/.agents/.DS_Store" 2>/dev/null || true | ||
| rmdir "$path_to_remove/.agent" 2>/dev/null || true # Only removes if empty |
There was a problem hiding this comment.
This rmdir command seems to be targeting the old .agent directory, while the preceding rm commands target subdirectories of the new .agents directory. This is inconsistent. It should likely target .agents to attempt to remove the new directory if it becomes empty.
Suggested change
| rmdir "$path_to_remove/.agent" 2>/dev/null || true # Only removes if empty | |
| rmdir "$path_to_remove/.agents" 2>/dev/null || true # Only removes if empty |
| rm -rf "$worktree_path/.agents/loop-state" 2>/dev/null || true | ||
| rm -rf "$worktree_path/.agents/tmp" 2>/dev/null || true | ||
| rm -f "$worktree_path/.agents/.DS_Store" 2>/dev/null || true | ||
| rmdir "$worktree_path/.agent" 2>/dev/null || true |
There was a problem hiding this comment.
Similar to the issue in cmd_remove, this rmdir command targets the old .agent directory. It should likely be .agents for consistency with the cleanup of the new directory structure.
Suggested change
| rmdir "$worktree_path/.agent" 2>/dev/null || true | |
| rmdir "$worktree_path/.agents" 2>/dev/null || true |
This was referenced Mar 7, 2026
marcusquinn
added a commit
that referenced
this pull request
Mar 8, 2026
…se args (GH#3816) Address remaining unactioned CodeRabbit review feedback from PR #14: - ralph-loop-helper.sh run_v2_loop: validate --max-iterations is a positive integer, --completion-promise is non-empty, --max-attempts is a positive integer. Previously these accepted any value silently. - ralph-loop-helper.sh setup_loop: add matching validation for --max-iterations and --completion-promise for consistency. - quality-loop-helper.sh: add --max-iterations validation to preflight_loop, pr_review_loop, and postflight_loop. All now reject non-positive-integer values with a clear error message instead of silently accepting them. Other PR #14 findings (aider duplicate prompt, || true hiding failures, missing tool existence check, invalid --monitor-duration, relative git_common_dir) were already fixed in subsequent PRs #35, #104, #111, #396, #480.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agent/directory to.agents/to align with emerging industry convention (matchingAGENTS.md)setup.shfor existing users (symlinks, gitignore, loop-state, AI configs)aidevops.sh initto create.agentssymlinks with automatic.agentmigrationMigration Strategy
For existing users (handled automatically by
setup.sh):.agentsymlinks in user projects →.agents.agent/loop-state/→.agents/loop-state/.gitignoreentries updatedFor the aidevops repo itself:
git mv .agent .agents(preserves git history).agent/→.agents/in file contents.agentreferences updated (symlink creation, gitignore entries)deploy_aidevops_agents()source_dir updatedKey Changes
setup.shmigrate_agent_to_agents_folder()function, updateddeploy_aidevops_agents()source_dir, updatedmigrate_loop_state_directories()aidevops.shcmd_init()to create.agentssymlink with.agentmigration.gitignore.agent/entries to.agents/sonar-project.propertieshomebrew/aidevops.rb.agents/**filesTesting
setup.shandaidevops.sh(no new warnings).agent-workspace,user-agent,.agent.SEO(jq paths) preserved