Skip to content

fix: HIGH quality-debt batch — logic bugs, exit codes, path typo, arg guards #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 5 commits into from
Mar 9, 2026
Merged

fix: HIGH quality-debt batch — logic bugs, exit codes, path typo, arg guards #3947

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
841a771
fix: HIGH quality-debt batch — logic bugs, exit codes, path typo, arg…
Mar 9, 2026
f0b6645
fix: address CodeRabbit review — success banner ordering, flag-like a…
Mar 9, 2026
c5173f1
fix: 8 shell scripts — filename bug, arg guards, trap cleanup, stderr…
Mar 9, 2026
1e10411
fix: ttsr-rule-loader — session-stable state file, safe JSON construc…
Mar 9, 2026
75edd59
fix: package.json main entry, Python singular/plural grammar
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .agents/scripts/email-batch-convert-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ cmd_convert() {
fi
done < <(find "$input_dir" -type f \( -name "*.eml" -o -name "*.msg" \) -print0 2>/dev/null)

if [[ "$count" -gt 0 && "$success" -eq 0 ]]; then
print_error "Conversion complete: ${success}/${count} succeeded, ${failed} failed"
print_error "All conversions failed"
return 1
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.
print_success "Conversion complete: ${success}/${count} succeeded, ${failed} failed"
return 0
}
Expand Down
3 changes: 0 additions & 3 deletions .agents/scripts/model-registry-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,6 @@ sync_providers() {
" 2>/dev/null || echo "")

# If recent successful sync, skip
if [[ -n "$opencode_synced" && "$opencode_synced" != "0" ]]; then
return 0
fi
if [[ -n "$opencode_synced" && "$opencode_synced" -gt 0 ]]; then
print_info "Skipping direct API probing (OpenCode sync already discovered $opencode_synced models)"
return 0
Expand Down
Loading
Loading