Skip to content

GH#3931: fix pulse-wrapper.sh BASH_SOURCE undefined in zsh #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 2 commits into from
Mar 9, 2026
Merged

GH#3931: fix pulse-wrapper.sh BASH_SOURCE undefined in zsh #3935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d7f9e
fix: replace BASH_SOURCE[0] with shell-portable alternative in pulse-…
marcusquinn Mar 9, 2026
96d08c8
fix: address CodeRabbit and Gemini review feedback on BASH_SOURCE fix
marcusquinn Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions .agents/scripts/pulse-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ set -euo pipefail
#######################################
export PATH="/bin:/usr/bin:/usr/local/bin:/opt/homebrew/bin:${PATH}"

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit
# Use ${BASH_SOURCE[0]:-$0} for shell portability — BASH_SOURCE is undefined
# in zsh, which is the MCP shell environment. This fallback ensures SCRIPT_DIR
# resolves correctly whether the script is executed directly (bash) or sourced
# from zsh. See GH#3931.
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)" || return 2>/dev/null || exit
source "${SCRIPT_DIR}/shared-constants.sh"
source "${SCRIPT_DIR}/worker-lifecycle-common.sh"

Expand Down Expand Up @@ -2998,6 +3002,20 @@ calculate_max_workers() {
# The pulse agent sources this file to access helper functions
# (check_external_contributor_pr, check_permission_failure_pr)
# without triggering the full pulse lifecycle.
if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
#
# Shell-portable source detection (GH#3931):
# bash: BASH_SOURCE[0] differs from $0 when sourced
# zsh: BASH_SOURCE is undefined; use ZSH_EVAL_CONTEXT instead
# (contains "file" when sourced, "toplevel" when executed)
_pulse_is_sourced() {
if [[ -n "${BASH_SOURCE[0]:-}" ]]; then
[[ "${BASH_SOURCE[0]}" != "${0}" ]]
elif [[ -n "${ZSH_EVAL_CONTEXT:-}" ]]; then
[[ ":${ZSH_EVAL_CONTEXT}:" == *":file:"* ]]
else
return 1
fi
}
if ! _pulse_is_sourced; then
main "$@"
fi
Loading