Skip to content

t1406: Filter out approving reviews from quality-debt issue creation #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 3 commits into from
Mar 9, 2026
Merged

t1406: Filter out approving reviews from quality-debt issue creation #3926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cfc580
fix: filter out approving reviews from quality-debt issue creation (t…
Mar 8, 2026
e122f69
fix: improve actionable-language regex patterns (Gemini review)
Mar 8, 2026
dfd1854
fix: escape single quote in jq regex to fix ShellCheck parsing errors…
marcusquinn Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .agents/scripts/quality-feedback-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,23 @@ _scan_single_pr() {

select($sev_num >= $min_num) |

# Skip approval-only reviews with no substantive body
select(.state != "APPROVED" or (.body | length) > 100) |
# Filter out approving reviews with no actionable feedback (t1406).
# APPROVED reviews from bots often contain long summaries/walkthroughs
# that are purely positive — these should not create quality-debt issues.
# Keep the review only if: (a) not APPROVED, or (b) body contains
# actionable language (suggestions, warnings, bugs, fix proposals).
(if .state == "APPROVED" then
($body | test(
"\\bshould\\b|\\bconsider\\b|\\binstead\\b|\\bsuggest|\\brecommend|" +
"\\bwarning\\b|\\bcaution\\b|\\bavoid\\b|\\b(don ?'"'"'?t|do not)\\b|" +
"\\bvulnerab|\\binsecure|\\binjection\\b|\\bxss\\b|\\bcsrf\\b|" +
"\\bnit:|\\btodo:|\\bfixme|\\bhardcoded|\\bdeprecated|" +
"\\brace.condition|\\bdeadlock|\\bleak|\\boverflow|" +
"\\bworkaround\\b|\\bhack\\b|" +
"```\\s*(suggestion|diff)"; "i"))
else true
end) |
select(.) |

{
pr: ($pr | tonumber),
Expand Down
Loading