Skip to content

t3027: Fix classify invocation to pass title as positional argument#3041

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/t3027-classify-positional-arg
Mar 7, 2026
Merged

t3027: Fix classify invocation to pass title as positional argument#3041
marcusquinn merged 1 commit intomainfrom
bugfix/t3027-classify-positional-arg

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Fix classify call in new-task.md Step 5.5 to pass the title as a positional argument instead of using the --task flag
  • cmd_classify() in task-decompose-helper.sh expects the description as $1 (positional), not as --task <value> — the old invocation caused the helper to classify the literal string --task instead of the actual title
  • Also removes --quiet which is not a recognized flag for cmd_classify()

Review Feedback Addressed

From CodeRabbit review on PR #3037 (major severity):

Line 121 calls classify --task "{title}" --quiet, but the provided cmd_classify() implementation only accepts the description as a positional arg plus --lineage/--depth. With the current parser, --task becomes the description, so this branch classifies the literal string --task instead of the real title.

Replaces

PR #3037 (closed — had merge conflict after #3040 merged the 2>/dev/null fix separately)

Closes #3027

The classify call used `--task "{title}" --quiet` but cmd_classify()
expects the description as a positional argument, not a --task flag.
This caused the helper to classify the literal string "--task" instead
of the actual title. Remove the --task flag and --quiet (not recognized
flags) so the title is passed positionally as cmd_classify() expects.

Addresses CodeRabbit review feedback on PR #3037.

Closes #3027
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions bot added the bug Auto-created from TODO.md tag label Mar 7, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8e5586d-a8d6-4b56-a31f-d84f597f8b85

📥 Commits

Reviewing files that changed from the base of the PR and between 731a9c7 and 261101b.

📒 Files selected for processing (1)
  • .agents/scripts/commands/new-task.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t3027-classify-positional-arg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 108 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sat Mar 7 05:20:13 UTC 2026: Code review monitoring started
Sat Mar 7 05:20:14 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 108

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 108
  • VULNERABILITIES: 0

Generated on: Sat Mar 7 05:20:16 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2026

@marcusquinn marcusquinn merged commit 114404c into main Mar 7, 2026
19 checks passed
@marcusquinn marcusquinn deleted the bugfix/t3027-classify-positional-arg branch March 7, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Auto-created from TODO.md tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: .agents/scripts/commands/new-task.md — PR #2997 review feedback (medium)

1 participant