GH#2946: fix quality-debt in pulse-wrapper.sh from PR #2944 review feedback

[marcusquinn]

Summary

• Remove 2>/dev/null from jq command in cleanup_worktrees() (line 1247) — the || echo "" already handles jq failures under set -e, and suppressing stderr hides malformed JSON or permission errors
• Remove 2>/dev/null from git worktree list command (line 1255) — the .git directory existence is already checked on the preceding line, making file-not-found suppression redundant while masking other diagnostic errors

Root Cause

Blanket stderr suppression (2>/dev/null) was applied defensively but is redundant when prior checks (file existence, || echo "" fallback) already handle the expected failure modes. The suppression masks unexpected errors (permissions, malformed config) that would aid debugging.

Review Feedback Source

Both findings from Gemini Code Assist review on PR #2944:

• Comment on line 1244
• Comment on line 1252

Testing

• ShellCheck passes with no new violations (only pre-existing SC1091 info for external source)
• Changes are minimal and mechanical — removing error suppression, not altering logic

Closes #2946

[coderabbitai]

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 309c6879-ba61-4f3b-82b9-8b78885d1da0

📥 Commits

Reviewing files that changed from the base of the PR and between 8733525 and db9a293.

📒 Files selected for processing (1)

• .agents/scripts/pulse-wrapper.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/pulse-wrapper-quality-debt

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 108 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Fri Mar 6 16:57:47 UTC 2026: Code review monitoring started
Fri Mar 6 16:57:48 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 108

📈 Current Quality Metrics

• BUGS: 0
• CODE SMELLS: 108
• VULNERABILITIES: 0

Generated on: Fri Mar 6 16:57:50 UTC 2026

---

Generated by AI DevOps Framework Code Review Monitoring

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the pulse-wrapper.sh script by removing unnecessary standard error suppression from two key commands. The change aims to enhance the script's robustness and debuggability by allowing potential errors, which are either already gracefully handled or indicative of genuine problems, to be visible rather than silently discarded. This ensures that unexpected issues can be more easily identified and addressed.

Highlights

• Error Handling Improvement: Removed redundant 2>/dev/null error suppression from the jq command within the cleanup_worktrees() function, as || echo "" already handles expected failures and suppressing stderr could hide critical issues.
• Git Command Robustness: Eliminated 2>/dev/null from the git worktree list command, enhancing debuggability by allowing actual errors to surface instead of being silently discarded, especially since prior checks already validate directory existence.
• Quality Debt Resolution: Addressed specific quality debt identified during a review of a previous pull request (PR GH#2941: fix multi-repo worktree auto-cleanup in pulse-wrapper.sh #2944), improving the script's maintainability and diagnostic capabilities.

Changelog

• .agents/scripts/pulse-wrapper.sh
  • Removed 2>/dev/null from the jq command in cleanup_worktrees().
  • Removed 2>/dev/null from the git worktree list command in cleanup_worktrees().

Activity

• This pull request was created to fix quality debt identified during a Gemini Code Assist review on PR GH#2941: fix multi-repo worktree auto-cleanup in pulse-wrapper.sh #2944, specifically addressing comments on line 1244 and line 1252.
• The changes were tested to ensure ShellCheck passes with no new violations and that the mechanical changes do not alter logic.
• This PR closes issue quality-debt: .agents/scripts/pulse-wrapper.sh — PR #2944 review feedback (medium) #2946.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses quality debt by removing unnecessary stderr suppression (2>/dev/null) in pulse-wrapper.sh. The changes correctly remove suppression from a jq command, where a fallback already handles failures, and from a git worktree list command, where a preceding check makes the suppression redundant. These improvements enhance debuggability by allowing potential errors to be visible, aligning with repository best practices. The changes are well-justified and correctly implemented.

_{Note: Security Review did not run due to the size of the PR.}