Skip to content

fix: install memory pressure monitor via setup.sh for reboot survival#2965

Merged
marcusquinn merged 1 commit intomainfrom
chore/setup-memory-monitor-install
Mar 6, 2026
Merged

fix: install memory pressure monitor via setup.sh for reboot survival#2965
marcusquinn merged 1 commit intomainfrom
chore/setup-memory-monitor-install

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Memory pressure monitor (memory-pressure-monitor.sh) was deployed but not auto-installed by setup.sh — it didn't survive reboots or aidevops update
  • Adds launchd plist generation (macOS, 60s interval, RunAtLoad=true) and cron entry (Linux) alongside the existing process guard block
  • No consent gate — this is a safety net (auto-kills runaway ShellCheck at >4 GB RSS), same as the process guard

Context

The t1398 series (PRs #2855, #2881, #2882, #2883, #2884, #2885, #2918, #2930) fixed the root cause of memory blowups (ShellCheck --external-sources exponential expansion inside Tabby's bash language server). The memory pressure monitor is the defense-in-depth layer — but it was only installable via --install flag, not auto-deployed by setup.sh. After a reboot, the monitor wasn't running.

Verification

  • ShellCheck clean on setup.sh
  • Follows exact same pattern as the process guard block (lines 980-1056)
  • Plist matches the one generated by memory-pressure-monitor.sh --install
  • Monitor confirmed running after manual install: launchctl list | grep memory-pressure

The memory-pressure-monitor.sh (t1398.5, GH#2915) was deployed but not
auto-installed by setup.sh, so it didn't survive reboots or aidevops
updates. Adds launchd plist generation (macOS) and cron entry (Linux)
alongside the existing process guard block. No consent needed — this is
a safety net that auto-kills runaway ShellCheck processes before they
cause kernel panics.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions bot added the bug Auto-created from TODO.md tag label Mar 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea569532-f8eb-4c06-ba81-5eb47d43eeee

📥 Commits

Reviewing files that changed from the base of the PR and between d79cc43 and a5b1520.

📒 Files selected for processing (1)
  • setup.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/setup-memory-monitor-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 108 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Fri Mar 6 03:00:55 UTC 2026: Code review monitoring started
Fri Mar 6 03:00:56 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 108

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 108
  • VULNERABILITIES: 0

Generated on: Fri Mar 6 03:00:59 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@marcusquinn
Copy link
Owner Author

This PR appears orphaned — no active worker process found and no activity for 6+ hours. Flagging for re-dispatch. If work is still in progress, remove the status:orphaned label.

@marcusquinn marcusquinn merged commit 35f34ca into main Mar 6, 2026
19 of 20 checks passed
@marcusquinn marcusquinn deleted the chore/setup-memory-monitor-install branch March 6, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Auto-created from TODO.md tag status:orphaned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant