t1405: Fix HIGH quality-debt in setup.sh from PR #2936 review

[marcusquinn]

Summary

• Remove 2>/dev/null from cmd_set calls (lines 815, 821) so users see errors when consent persistence fails — prevents silent re-prompting on next run
• Remove 2>/dev/null from grep on legacy config (line 773) where file existence is already verified — suppressing stderr masks permission errors
• Single-quote variable expansions in crontab entry (line 924) to prevent command injection via directory names with shell metacharacters

Details

Addresses all 4 findings from Gemini code review on PR #2936:

• 2x HIGH: Error suppression on cmd_set consent persistence
• 2x MEDIUM: Redundant error suppression on grep + command injection in crontab

ShellCheck passes clean.

Closes #2950

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e6793001-5df6-43fa-83b7-980cfe10b7fa

📥 Commits

Reviewing files that changed from the base of the PR and between d79cc43 and 602f413.

📒 Files selected for processing (1)

• setup.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/setup-quality-debt-2950

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 108 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Fri Mar 6 02:54:02 UTC 2026: Code review monitoring started
Fri Mar 6 02:54:03 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 108

📈 Current Quality Metrics

• BUGS: 0
• CODE SMELLS: 108
• VULNERABILITIES: 0

Generated on: Fri Mar 6 02:54:06 UTC 2026

---

Generated by AI DevOps Framework Code Review Monitoring

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[marcusquinn]

This PR appears orphaned — no active worker process found and no activity for 6+ hours. Flagging for re-dispatch. If work is still in progress, remove the status:orphaned label.

[marcusquinn]

Closing — all 4 fixes in this PR were already merged via PR #2994 (commit 1502cbc), which addressed the same issue #2950 with a more comprehensive solution (awk replacement for grep pipeline, shell_single_quote utility for crontab injection prevention). Rebasing would produce an empty diff.