t2957: Stop suppressing stderr in version checks for debuggability#2959
t2957: Stop suppressing stderr in version checks for debuggability#2959marcusquinn merged 2 commits intomainfrom
Conversation
Remove blanket 2>/dev/null from timeout_sec version check call so that error messages from version commands (permission issues, missing dependencies) remain visible for debugging instead of being silently discarded. Closes #2957
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the debuggability of tool version checks by ensuring that error output from command executions is no longer suppressed. By allowing standard error streams to pass through, diagnostic information becomes immediately visible, significantly aiding in troubleshooting issues related to command failures or unexpected behavior during version verification. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Mar 6 02:41:44 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the suppression of stderr from the version check command in tool-version-check.sh. This is a valuable change that improves debuggability by ensuring that error messages from underlying tool commands are no longer hidden. The implementation is correct and aligns with the project's general rules against blanket error suppression.
The workflow fired on pull_request (opened/synchronize) and immediately failed because no bots had posted yet (takes 30s-2min). This created a permanent failed check even though the re-trigger on pull_request_review passed seconds later. Fix: when no bots are found and the PR is younger than MIN_WAIT_SECONDS (120s), pass with a 'pending' note instead of failing. The gate still hard-fails for PRs older than the threshold where bots should have posted. The check re-runs automatically when bots post via pull_request_review or issue_comment triggers.
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Mar 6 03:04:14 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
1 participant
Summary
2>/dev/nullfrom thetimeout_secversion check call intool-version-check.shso that error messages (permission issues, missing dependencies) remain visible for debuggingDetails
The
2>/dev/nullon thetimeout_seccall was suppressing all stderr output from version commands. While this kept output clean, it hid important diagnostic information when commands failed for reasons other than hanging (e.g., permission denied, missing shared libraries, auth errors). Removing it lets stderr flow through to the caller for visibility while stdout still goes to the temp file for version string parsing.Closes #2957