Skip to content

t2865: Remove stderr suppression from write_proof_log calls in deploy.sh#2888

Merged
alex-solovyev merged 1 commit intomainfrom
bugfix/t2865-deploy-stderr-suppression
Mar 5, 2026
Merged

t2865: Remove stderr suppression from write_proof_log calls in deploy.sh#2888
alex-solovyev merged 1 commit intomainfrom
bugfix/t2865-deploy-stderr-suppression

Conversation

@alex-solovyev
Copy link
Collaborator

@alex-solovyev alex-solovyev commented Mar 5, 2026

Summary

Closes #2865

Summary by CodeRabbit

  • Bug Fixes
    • Improved error visibility in deployment processes by enhancing error logging output, allowing diagnostic messages to surface during deployment operations for better troubleshooting.

Remove 2>/dev/null from all 6 write_proof_log calls in deploy.sh.
The || true already prevents script exit on failure, so suppressing
stderr just hides debugging info (path errors, permission issues).

Addresses review feedback from Gemini on PR #2845.
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the debuggability of the deploy.sh script by eliminating the suppression of standard error output from write_proof_log commands. This modification ensures that any errors generated by these logging calls, which were previously hidden, are now visible. The existing || true mechanism already prevents script termination on failure, so removing 2>/dev/null provides valuable diagnostic information without altering the script's error handling flow.

Highlights

  • Stderr Suppression Removed: Removed 2>/dev/null from all six write_proof_log calls within the deploy.sh script. This change allows standard error messages to be visible, aiding in debugging.
  • Improved Debuggability: The removal of stderr suppression ensures that potential issues like log file path errors or permission problems are no longer silently discarded, making the script easier to troubleshoot.
Changelog
  • .agents/scripts/supervisor-archived/deploy.sh
    • Removed 2>/dev/null from write_proof_log calls to expose stderr.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d94d883-bc4b-4d72-8ddd-263612ee33b1

📥 Commits

Reviewing files that changed from the base of the PR and between f8589bf and 2ae4149.

📒 Files selected for processing (1)
  • .agents/scripts/supervisor-archived/deploy.sh

Walkthrough

This PR removes explicit stderr redirections (2>/dev/null) from write_proof_log and related logging commands in the deploy script, surfacing errors for debugging purposes while preserving error handling through existing conditional chaining patterns.

Changes

Cohort / File(s) Summary
Error Suppression Cleanup
.agents/scripts/supervisor-archived/deploy.sh
Removed 2>/dev/null redirections from write_proof_log invocations and related status logging to ensure command errors become visible for debugging, maintaining error handling via existing || true conditionals.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

bug

Poem

🔍 No more silent shadows in the logs,
Errors emerge like morning fog,
Debugging blooms when truth flows free,
Debug logs shine for all to see! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: removing stderr suppression from write_proof_log calls in deploy.sh, matching the core objective.
Linked Issues check ✅ Passed The PR fully addresses issue #2865 by removing 2>/dev/null from all six write_proof_log invocations while maintaining non-fatal behavior via || true, as required.
Out of Scope Changes check ✅ Passed All changes are scoped to removing stderr suppression from write_proof_log calls in deploy.sh; no unrelated modifications detected.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t2865-deploy-stderr-suppression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 107 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Thu Mar 5 05:24:02 UTC 2026: Code review monitoring started
Thu Mar 5 05:24:03 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 107

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 107
  • VULNERABILITIES: 0

Generated on: Thu Mar 5 05:24:05 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@alex-solovyev
Copy link
Collaborator Author

This PR addresses issue #2865 (remove stderr suppression from write_proof_log calls in supervisor-archived/deploy.sh). Waiting for CodeRabbit review to complete before merge.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes stderr suppression (2>/dev/null) from six calls to write_proof_log in the deploy.sh script. This is a valuable change that improves debuggability by allowing potential errors from the logging function to be visible, while the existing || true continues to prevent script termination on failure. The implementation is correct and aligns with best practices for robust shell scripting, including several of the project's general rules that advise against blanket error suppression.

@alex-solovyev alex-solovyev merged commit 1df3e8c into main Mar 5, 2026
27 of 28 checks passed
@alex-solovyev alex-solovyev deleted the bugfix/t2865-deploy-stderr-suppression branch March 5, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: .agents/scripts/supervisor-archived/deploy.sh — PR #2845 review feedback (medium)

1 participant