t2865: Remove stderr suppression from write_proof_log calls in deploy.sh#2888
Conversation
Remove 2>/dev/null from all 6 write_proof_log calls in deploy.sh. The || true already prevents script exit on failure, so suppressing stderr just hides debugging info (path errors, permission issues). Addresses review feedback from Gemini on PR #2845.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the debuggability of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR removes explicit stderr redirections ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Thu Mar 5 05:24:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
|
This PR addresses issue #2865 (remove stderr suppression from write_proof_log calls in supervisor-archived/deploy.sh). Waiting for CodeRabbit review to complete before merge. |
There was a problem hiding this comment.
Code Review
This pull request removes stderr suppression (2>/dev/null) from six calls to write_proof_log in the deploy.sh script. This is a valuable change that improves debuggability by allowing potential errors from the logging function to be visible, while the existing || true continues to prevent script termination on failure. The implementation is correct and aligns with best practices for robust shell scripting, including several of the project's general rules that advise against blanket error suppression.



Summary
2>/dev/nullfrom all 6write_proof_logcalls in.agents/scripts/supervisor-archived/deploy.sh|| truealready prevents script exit on failure, so2>/dev/nullonly hides useful debugging info (log file path errors, permission issues)Closes #2865
Summary by CodeRabbit