Skip to content

t1400: Replace kill -0 with ps -p and remove redundant 2>/dev/null in pulse-wrapper.sh #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Mar 5, 2026
Merged

t1400: Replace kill -0 with ps -p and remove redundant 2>/dev/null in pulse-wrapper.sh #2879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .agents/scripts/pulse-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ check_dedup() {
fi

# Check if the process is still running
if ! kill -0 "$old_pid" 2>/dev/null; then
if ! ps -p "$old_pid" >/dev/null; then
# Process is dead, clean up stale PID file
rm -f "$PIDFILE"
return 0
Expand All @@ -147,7 +147,7 @@ check_dedup() {
_kill_tree "$old_pid"
sleep 2
# Force kill if still alive
if kill -0 "$old_pid" 2>/dev/null; then
if ps -p "$old_pid" >/dev/null; then
_force_kill_tree "$old_pid"
fi
rm -f "$PIDFILE"
Expand Down Expand Up @@ -928,7 +928,7 @@ guard_child_processes() {
echo "[pulse-wrapper] Process guard: killing PID $pid ($cmd_base) — $violation" >>"$LOGFILE"
_kill_tree "$pid"
sleep 1
if kill -0 "$pid" 2>/dev/null; then
if ps -p "$pid" >/dev/null; then
_force_kill_tree "$pid"
fi
killed=$((killed + 1))
Expand Down Expand Up @@ -1019,7 +1019,7 @@ ${state_content}
# the stale threshold. Also runs process guard to kill runaway children (t1398).
# This replaces the bare `wait` that blocked the wrapper indefinitely when
# opencode hung.
while kill -0 "$opencode_pid" 2>/dev/null; do
while ps -p "$opencode_pid" >/dev/null; do
local now
now=$(date +%s)
local elapsed=$((now - start_epoch))
Expand All @@ -1028,7 +1028,7 @@ ${state_content}
_kill_tree "$opencode_pid"
sleep 2
# Force kill if still alive
if kill -0 "$opencode_pid" 2>/dev/null; then
if ps -p "$opencode_pid" >/dev/null; then
_force_kill_tree "$opencode_pid"
fi
break
Expand All @@ -1038,7 +1038,7 @@ ${state_content}
# CHILD_RUNTIME_LIMIT (it's governed by PULSE_STALE_THRESHOLD above).
guard_child_processes "$opencode_pid"
# Sleep 60s then re-check. Portable across bash 3.2+ (macOS default).
# The process may exit during sleep — kill -0 at top of loop catches that.
# The process may exit during sleep — ps -p at top of loop catches that.
sleep 60
done

Expand Down Expand Up @@ -1635,7 +1635,7 @@ run_daily_quality_sweep() {
# Timestamp guard — run at most once per QUALITY_SWEEP_INTERVAL
if [[ -f "$QUALITY_SWEEP_LAST_RUN" ]]; then
local last_run
last_run=$(cat "$QUALITY_SWEEP_LAST_RUN" 2>/dev/null || echo "0")
last_run=$(cat "$QUALITY_SWEEP_LAST_RUN" || echo "0")
# Strip whitespace/newlines and validate integer (t1397)
last_run="${last_run//[^0-9]/}"
last_run="${last_run:-0}"
Expand Down