t2819: replace 2>/dev/null with --silent on gh api label POST calls#2829
t2819: replace 2>/dev/null with --silent on gh api label POST calls#2829alex-solovyev merged 1 commit intomainfrom
Conversation
Addresses quality-debt review feedback from PR #2794 (Gemini). 2>/dev/null suppresses all stderr, hiding auth, network, and API errors. gh api --silent only suppresses the successful JSON response body on stdout while preserving genuine error output on stderr. The || true already handles non-zero exit codes for resilience. Three call sites updated: - pulse.md:279 (orphaned PR labeling) - pulse-wrapper.sh:660 (external-contributor label re-add) - pulse-wrapper.sh:671 (external-contributor label on first flag) Closes #2819
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThese changes replace stderr redirection ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Mar 4 15:28:07 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness and debuggability of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request replaces 2>/dev/null with the --silent flag on three gh api calls within .agents/scripts/commands/pulse.md and .agents/scripts/pulse-wrapper.sh. This change modifies error handling by allowing genuine errors (e.g., authentication, network issues) to be printed to stderr, which were previously suppressed. The --silent flag correctly suppresses the JSON response body on stdout for successful calls, while the || true construct is retained to prevent script termination on failure. The changes are consistent and correctly implemented as described.
Note: Security Review did not run due to the size of the PR.



Summary
2>/dev/nullwith--silentflag on threegh apilabel POST calls inpulse.mdandpulse-wrapper.sh2>/dev/nullsuppresses all stderr including auth/network/API errors, making debugging difficult--silentonly suppresses the successful JSON response body on stdout while preserving genuine error output on stderrChanges
.agents/scripts/commands/pulse.md(1 site):status:orphanedlabel application.agents/scripts/pulse-wrapper.sh(2 sites):external-contributorlabel re-add (when comment exists but label is missing)external-contributorlabel on first flagAll three retain
|| truefor resilience — the change only affects error visibility, not control flow.Context
Addresses quality-debt review feedback from Gemini on PR #2794. The original PR replaced
gh pr edit --add-labelwithgh apiREST calls (fixing a GraphQL deprecation issue), but used2>/dev/nullfor error suppression. The reviewer correctly noted this hides genuine errors and suggested--silentinstead.Closes #2819
Summary by CodeRabbit