Skip to content

t2814: Remove 2>/dev/null from pulse external-contributor label API calls #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-solovyev wants to merge 1 commit into from
Closed

t2814: Remove 2>/dev/null from pulse external-contributor label API calls #2822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/scripts/commands/pulse.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,12 @@ if [[ $label_exit -ne 0 || $comment_exit -ne 0 ]]; then
elif [[ "$has_label" == "true" || "$has_comment" == "true" ]]; then
# Already flagged. Re-add label if missing (comment exists but label doesn't).
if [[ "$has_label" == "false" ]]; then
gh api "repos/<slug>/issues/<number>/labels" -X POST -f 'labels[]=external-contributor' 2>/dev/null || true
gh api "repos/<slug>/issues/<number>/labels" -X POST -f 'labels[]=external-contributor' || true
fi
else
# Both API calls succeeded AND neither label nor comment exists — safe to post.
gh pr comment <number> --repo <slug> --body "This PR is from an external contributor (@<author>). Auto-merge is disabled for external PRs — a maintainer must review and merge manually." \
&& gh api "repos/<slug>/issues/<number>/labels" -X POST -f 'labels[]=external-contributor' 2>/dev/null || true
&& gh api "repos/<slug>/issues/<number>/labels" -X POST -f 'labels[]=external-contributor' || true
fi
```

Expand Down