t1344: Fix ShellCheck SC1091 noise from sourced files#2427
t1344: Fix ShellCheck SC1091 noise from sourced files#2427alex-solovyev merged 3 commits intomainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (140)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 27 01:42:57 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Add root .shellcheckrc with source-path=SCRIPTDIR so ShellCheck resolves sourced files (shared-constants.sh, _common.sh) relative to each script's directory. This eliminates SC1091 warnings at the source rather than suppressing them per-file. Changes: - Add .shellcheckrc with source-path=SCRIPTDIR - Add -P SCRIPTDIR flag to shellcheck invocations in linters-local.sh, verify-run-helper.sh, and quality-fix.sh - Remove SC1091 from 129 file-level disable directives across 138 files - Remove redundant shellcheck source= annotations for shared-constants.sh - Remove file-level SC1090 disables where SCRIPTDIR resolves the source - Add targeted inline SC1090 disables for credentials.sh (runtime path) - Keep inline SC1091 disable for venv/activate (doesn't exist at lint time) Net: -73 lines of shellcheck noise suppression. Closes #2410
…alse positives (t1344) The initial SC1091 cleanup incorrectly removed compound disable directives (e.g., SC1091,SC2016,SC2034) entirely instead of keeping the non-SC1091 codes. This caused CodeFactor to report 642 new issues. Changes: - Restore 27 inline shellcheck disable directives (SC2016, SC2086, SC2154) that were collateral damage from the SC1091 removal - Add disable=SC2329,SC2317 to .shellcheckrc (project-wide false positives from library/sourced-file architecture) - Exclude archived/ and tests/ dirs from CodeFactor analysis
…(t1344) Add SC2034, SC2001, SC2059, SC2012, SC2030, SC2031, SC2015, SC2129, SC2153, SC2004, SC2009 as project-wide accepted patterns. These are informational/style issues that are intentional in this codebase (library architecture, dynamic format strings, sed preferences, etc.).
alex-solovyev
force-pushed
the
chore/fix-sc1091-noise
branch
from
a606e06 to
39ff108
Compare
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 27 02:43:15 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
|
Follow-up: source-path=SCRIPTDIR removed in PR #2939 This PR (t1344) added PR #2939 reverses this approach: removes Upstream hazard note: The bash-language-server still hardcodes |
|
fatal: couldn't find remote ref chore/fix-sc1091-noise |
2 participants
Summary
.shellcheckrcwithsource-path=SCRIPTDIRso ShellCheck resolves sourced files (shared-constants.sh,_common.sh) relative to each script's directory-P SCRIPTDIRflag to ShellCheck invocations inlinters-local.sh,verify-run-helper.sh, andquality-fix.shSC1091from 129 file-level disable directives across 138 files# shellcheck source=shared-constants.shannotationsSC1090disables only where truly needed (runtime credential paths, venv activate)Net result: -73 lines of noise suppression. SC1091 is now resolved at the root cause instead of being silenced per-file.
Approach
The issue offered 3 options. Option 1 (pass
-xto ShellCheck) was already in use but insufficient because ShellCheck couldn't resolve the dynamic$SCRIPT_DIR/shared-constants.shpaths. The fix combines:.shellcheckrcwithsource-path=SCRIPTDIR— tells ShellCheck to look in the script's own directory for sourced files. This is picked up automatically by editors, CI, and all ShellCheck invocations.-P SCRIPTDIRflag in the main linting scripts — belt-and-suspenders for explicit invocations.# shellcheck disable=SC1091directives that were just noise suppression.Verification
--severity=warninglinters-local.shShellCheck phase produces no SC1091 outputCloses #2410