t1342: Add Linux cron support for pulse scheduler#2402
Conversation
…rvisor-helper.sh refs (t1342) - runners.md: add Linux (cron) section alongside macOS launchd instructions - setup.sh: replace dead supervisor-helper.sh pulse installer with cross-platform cron-based approach (works on macOS and Linux) - setup.sh: update help text to point to runners.md instead of deleted script Fixes #2401
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
WalkthroughDocumentation and setup logic for the pulse scheduler are refactored to support both macOS and Linux. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Thu Feb 26 23:00:09 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
setup.sh (1)
706-713: Quote the directory path in the cron command to handle paths with spaces.Line 708 constructs the pulse command with
$_aidevops_dirunquoted. If the path contains spaces (e.g.,/home/user/My Git/aidevops), the cron entry will parse incorrectly.🛡️ Proposed fix for path quoting
if [[ "$_install_pulse" == "true" ]]; then mkdir -p "$HOME/.aidevops/logs" - local _pulse_cmd="$opencode_path run \"/pulse\" --dir $_aidevops_dir -m anthropic/claude-sonnet-4-6 --title \"Supervisor Pulse\"" + local _pulse_cmd="$opencode_path run \"/pulse\" --dir \"$_aidevops_dir\" -m anthropic/claude-sonnet-4-6 --title \"Supervisor Pulse\"" # Install as cron entry (works on both macOS and Linux)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@setup.sh` around lines 706 - 713, The cron entry fails for directories with spaces because $_aidevops_dir is unquoted in the constructed _pulse_cmd and the crontab echo, so update the _pulse_cmd assignment (variable _pulse_cmd) to pass --dir "$_aidevops_dir" (i.e., quote the directory) and ensure the string written into crontab preserves that quoting (escape or wrap the entire cron command appropriately so the quoted path survives when echoing the line into crontab, e.g., ensure the crontab echo that includes $_pulse_cmd emits the command with the directory argument quoted).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@setup.sh`:
- Around line 706-713: The cron entry fails for directories with spaces because
$_aidevops_dir is unquoted in the constructed _pulse_cmd and the crontab echo,
so update the _pulse_cmd assignment (variable _pulse_cmd) to pass --dir
"$_aidevops_dir" (i.e., quote the directory) and ensure the string written into
crontab preserves that quoting (escape or wrap the entire cron command
appropriately so the quoted path survives when echoing the line into crontab,
e.g., ensure the crontab echo that includes $_pulse_cmd emits the command with
the directory argument quoted).
2 participants
Summary
runners.mdsupervisor-helper.shreferences insetup.shwith cross-platform cron installersetup.sh --non-interactiveinstalls pulse cron entry on Linux, ShellCheck cleanFixes #2401
Summary by CodeRabbit
New Features
Documentation
Improvements