chore: scrub private repo references from public codebase#2204
chore: scrub private repo references from public codebase#2204marcusquinn merged 1 commit intomainfrom
Conversation
Replace all 'awardsapp' references with generic 'webapp' across 11 files: TODO.md, VERIFY.md, todo/VERIFY.md, CHANGELOG.md, localdev-helper.sh, local-hosting.md, dispatch.sh, deploy.sh, ai-actions.sh, migrations.sh, test-ai-actions.sh. Prevents private project name leaking in public repo.
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the privacy and generic nature of the codebase by systematically removing references to a specific private project. The primary goal was to replace all occurrences of 'a managed private repo' with 'webapp' across various files, ensuring that the public repository remains free of sensitive project names. This change is purely cosmetic and informational, with no functional impact on the system, and includes a related cleanup of misfiled GitHub issues. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughA comprehensive refactoring replaces "a managed private repo" references with "webapp" across DevOps automation scripts, supervisor tools, configuration generators, and documentation. Changes include shell script function renaming, Traefik routing configuration updates, task tracking references, and test examples. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Feb 24 04:21:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agents/scripts/localdev-helper.sh:
- Line 188: There is a ShellCheck SC2086 warning for an unquoted variable
expansion in the "Preserves existing routes (e.g., webapp) by splitting into
per-app files." block; locate the unquoted parameter expansion around that
section (the token causing SC2086, e.g., an instance of $FOO or $routes used
without quotes) and wrap it in double quotes (change $var to "$var") to prevent
globbing/word-splitting, then re-run .agents/scripts/linters-local.sh to verify
the warning is resolved before committing.
In @.agents/scripts/supervisor/ai-actions.sh:
- Around line 1446-1450: ShellCheck flagged three sed usages with SC2016 and
three source directives with SC1091; for the sed instances (the sed commands
that currently use single-quoted patterns) decide whether variables should
expand—if they should, change the pattern quotes to double quotes so variables
expand (or concatenate the variable outside the single-quoted literal),
otherwise add an inline comment clarifying the literal intent or escape the $ to
silence ShellCheck; for the SC1091 source warnings, update the source statements
to use explicit, resolvable paths (e.g., build an absolute path with dirname
"$0") and guard them with if [ -f ... ]; then . "path"; fi or run shellcheck
with -x in CI so external sourced files are included; after making these
changes, run shellcheck (shellcheck -x) and ensure exit code 0.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.agents/scripts/localdev-helper.sh.agents/scripts/supervisor/ai-actions.sh.agents/scripts/supervisor/deploy.sh.agents/scripts/supervisor/dispatch.sh.agents/services/hosting/local-hosting.mdCHANGELOG.mdTODO.mdVERIFY.mdsetup-modules/migrations.shtests/test-ai-actions.shtodo/VERIFY.md
| # ============================================================================= | ||
| # Migrates from single dynamic.yml to conf.d/ directory provider. | ||
| # Preserves existing routes (e.g., awardsapp) by splitting into per-app files. | ||
| # Preserves existing routes (e.g., webapp) by splitting into per-app files. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Run ShellCheck on the target script
if [ -f ".agents/scripts/localdev-helper.sh" ]; then
echo "=== Running ShellCheck ==="
shellcheck -x -f gcc .agents/scripts/localdev-helper.sh 2>&1 || true
else
echo "File not found: .agents/scripts/localdev-helper.sh"
fiRepository: marcusquinn/aidevops
Length of output: 202
🏁 Script executed:
#!/bin/bash
# Examine the changed lines to understand the modifications
echo "=== Changed line 188 ==="
sed -n '185,191p' .agents/scripts/localdev-helper.sh | cat -n
echo -e "\n=== Changed lines 225-233 ==="
sed -n '225,233p' .agents/scripts/localdev-helper.sh | cat -n
echo -e "\n=== Changed lines 239-270 ==="
sed -n '239,270p' .agents/scripts/localdev-helper.sh | cat -n
echo -e "\n=== Changed line 2308 ==="
sed -n '2305,2311p' .agents/scripts/localdev-helper.sh | cat -nRepository: marcusquinn/aidevops
Length of output: 2483
🏁 Script executed:
#!/bin/bash
# Check script size and overall structure
echo "=== Script statistics ==="
wc -l .agents/scripts/localdev-helper.sh
echo ""
echo "=== Verify script is executable and well-formed ==="
bash -n .agents/scripts/localdev-helper.sh && echo "✓ Syntax valid" || echo "✗ Syntax error"Repository: marcusquinn/aidevops
Length of output: 197
Address pre-existing ShellCheck violation before committing.
ShellCheck found a minor SC2086 note at line 1055 (double quote to prevent globbing). The changed segments are syntactically sound and follow proper shell scripting patterns (error redirects, conditionals, heredoc usage). Per guidelines, resolve the pre-existing SC2086 and run .agents/scripts/linters-local.sh before committing.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.agents/scripts/localdev-helper.sh at line 188, There is a ShellCheck SC2086
warning for an unquoted variable expansion in the "Preserves existing routes
(e.g., webapp) by splitting into per-app files." block; locate the unquoted
parameter expansion around that section (the token causing SC2086, e.g., an
instance of $FOO or $routes used without quotes) and wrap it in double quotes
(change $var to "$var") to prevent globbing/word-splitting, then re-run
.agents/scripts/linters-local.sh to verify the warning is resolved before
committing.
| # Resolve the task's repo from the supervisor DB (t1234, t1237). | ||
| # Tasks are always repo-specific — never guess by falling back to the | ||
| # primary repo, because task IDs can collide across repos (e.g., both | ||
| # aidevops and awardsapp have t003 for different things). Writing to | ||
| # aidevops and webapp have t003 for different things). Writing to | ||
| # the wrong repo is a privacy breach if repo visibility differs. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Run ShellCheck on the supervisor script
if [ -f ".agents/scripts/supervisor/ai-actions.sh" ]; then
echo "=== Running ShellCheck on ai-actions.sh ==="
shellcheck .agents/scripts/supervisor/ai-actions.sh 2>&1
exit_code=$?
echo ""
echo "Exit code: $exit_code"
if [ $exit_code -eq 0 ]; then
echo "✓ ShellCheck passed with no issues"
else
echo "✗ ShellCheck found issues (see above)"
fi
else
echo "File not found: .agents/scripts/supervisor/ai-actions.sh"
fiRepository: marcusquinn/aidevops
Length of output: 1937
ShellCheck found 6 info-level issues — review and address before commit.
ShellCheck reports:
- SC2016 (lines 1402, 2142, 2169): Single quotes in sed patterns flagged as preventing variable expansion. Verify if double quotes are needed or if these patterns are intentionally literal.
- SC1091 (lines 2393, 2395, 2397): Source directives not followed — run
shellcheck -xto include external sourced files and suppress these warnings.
Address the SC2016 warnings and confirm the file passes ShellCheck cleanly (exit code 0) per the A-grade automation toolchain standard.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.agents/scripts/supervisor/ai-actions.sh around lines 1446 - 1450,
ShellCheck flagged three sed usages with SC2016 and three source directives with
SC1091; for the sed instances (the sed commands that currently use single-quoted
patterns) decide whether variables should expand—if they should, change the
pattern quotes to double quotes so variables expand (or concatenate the variable
outside the single-quoted literal), otherwise add an inline comment clarifying
the literal intent or escape the $ to silence ShellCheck; for the SC1091 source
warnings, update the source statements to use explicit, resolvable paths (e.g.,
build an absolute path with dirname "$0") and guard them with if [ -f ... ];
then . "path"; fi or run shellcheck with -x in CI so external sourced files are
included; after making these changes, run shellcheck (shellcheck -x) and ensure
exit code 0.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively scrubs references to the private awardsapp repository, replacing them with the generic webapp across various files. The changes are straightforward string replacements in comments, documentation, and configuration examples, with no functional impact. I've identified one minor improvement opportunity in a shell script to remove unnecessary error suppression, which will enhance debuggability.
| create_awardsapp_confd | ||
| print_success "Migrated awardsapp route to conf.d/awardsapp.yml" | ||
| # Check if webapp route exists in dynamic.yml | ||
| if grep -q 'webapp' "$dynamic_yml" 2>/dev/null; then |
There was a problem hiding this comment.
The error suppression 2>/dev/null is unnecessary here as the existence of $dynamic_yml is already checked earlier in the migrate_traefik_to_confd function. Removing the suppression will make potential issues like file read permissions visible for easier debugging.
| if grep -q 'webapp' "$dynamic_yml" 2>/dev/null; then | |
| if grep -q 'webapp' "$dynamic_yml"; then |
References
- Avoid using
2>/dev/nullto suppress errors on file operations if the file's existence has already been verified by a preceding check (e.g.,[[ -f "$file" ]]or an early return). This practice is redundant for 'file not found' errors and can mask other important issues like permissions problems.
1 participant
Summary
a managed private reporeferences with genericwebappacross 11 filesFiles changed
TODO.mdVERIFY.mdtodo/VERIFY.mdCHANGELOG.md.agents/scripts/localdev-helper.sh.agents/services/hosting/local-hosting.md.agents/scripts/supervisor/dispatch.sh.agents/scripts/supervisor/deploy.sh.agents/scripts/supervisor/ai-actions.shsetup-modules/migrations.shtests/test-ai-actions.shRelated cleanup
Summary by CodeRabbit
Chores
Documentation
Tests