Skip to content

t1257: Add sequential dependency enforcement for t1120 subtask chain #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 1 commit into from
Feb 23, 2026
Merged

t1257: Add sequential dependency enforcement for t1120 subtask chain #2195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,9 +1591,9 @@ t019.3.4,Update AGENTS.md with Beads integration docs,,beads,1h,45m,2025-12-21T1
- Tested working prototype in a managed project repo: gitea-issue-sync.sh (separate script, ~600 lines)
- Key findings from testing: (1) `set -euo pipefail` + grep in pipelines needs `{ grep ... || true; }` guard, (2) macOS sed `\s` doesn't work — use `[[:space:]]`, (3) dots in task IDs (t007.1) need escaping in sed patterns, (4) Gitea label API returns IDs not names (need ID array in create payload)
- [x] t1120.1 Extract platform-agnostic functions from issue-sync-helper.sh (parse, compose, ref management) ~1h ref:GH#1676 assignee:marcusquinn started:2026-02-20T19:52:54Z pr:#2029 completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20
Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for this subtask is inconsistent with its siblings (t1120.1 and t1120.3). To maintain correct list formatting and hierarchy, it should have the same indentation level (2 spaces).

Suggested change
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20

- [x] t1120.3 Add platform detection from git remote URL + multi-platform push/pull/close ~1h ref:GH#1678 #auto-dispatch model:sonnet assignee:marcusquinn started:2026-02-18T22:07:40Z pr:#1815 completed:2026-02-18
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20
Comment on lines 1593 to +1596
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix list indentation to satisfy MD005.

The two changed subtask lines are indented one space too far, causing inconsistent list indentation. Align them with the other subtask entries.

🔧 Suggested fix 
-   - [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:`#2031` completed:2026-02-20
+  - [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:`#2031` completed:2026-02-20
-   - [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:`#2033` completed:2026-02-20
+  - [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:`#2033` completed:2026-02-20
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [x] t1120.1 Extract platform-agnostic functions from issue-sync-helper.sh (parse, compose, ref management) ~1h ref:GH#1676 assignee:marcusquinn started:2026-02-20T19:52:54Z pr:#2029 completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:#2031 completed:2026-02-20
- [x] t1120.3 Add platform detection from git remote URL + multi-platform push/pull/close ~1h ref:GH#1678 #auto-dispatch model:sonnet assignee:marcusquinn started:2026-02-18T22:07:40Z pr:#1815 completed:2026-02-18
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20
- [x] t1120.1 Extract platform-agnostic functions from issue-sync-helper.sh (parse, compose, ref management) ~1h ref:GH#1676 assignee:marcusquinn started:2026-02-20T19:52:54Z pr:`#2029` completed:2026-02-20
- [x] t1120.2 Add Gitea API adapter functions (create/close/edit/list/search/labels) ~1h ref:GH#1677 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T21:24:40Z pr:`#2031` completed:2026-02-20
- [x] t1120.3 Add platform detection from git remote URL + multi-platform push/pull/close ~1h ref:GH#1678 `#auto-dispatch` model:sonnet assignee:marcusquinn started:2026-02-18T22:07:40Z pr:`#1815` completed:2026-02-18
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:`#2033` completed:2026-02-20
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)

[warning] 1594-1594: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 3

(MD005, list-indent)

[warning] 1596-1596: Inconsistent indentation for list items at the same level
Expected: 2; Actual: 3

(MD005, list-indent)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@TODO.md` around lines 1593 - 1596, The two subtask lines for t1120.2 and
t1120.4 have one extra leading space causing inconsistent list indentation
(MD005); remove the extra leading space so each subtask line begins with "- [x]"
aligned with the other subtask entries under t1120.1/t1120.3 to restore
consistent markdown list indentation.

Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There are two potential improvements for this line:

  1. Dependency Chain: To ensure correct sequential execution, the testing task t1120.4 should depend on the Gitea API adapter from t1120.2 being complete. By setting blocked-by:t1120.2, you create a clear dependency chain: t1120.1 → t1120.2 → t1120.4.
  2. Indentation: The indentation is inconsistent with its siblings. It should be 2 spaces to match the others.

The suggested code applies both fixes.

Suggested change
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.1 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20
- [x] t1120.4 Test with dual-hosted repo (GitHub + Gitea sync) ~30m ref:GH#1679 blocked-by:t1120.2 assignee:marcusquinn started:2026-02-20T22:21:08Z pr:#2033 completed:2026-02-20


- [x] t1121 Fix tea CLI TTY requirement in non-interactive mode #bugfix #git ~30m model:haiku ref:GH#1680 assignee:marcusquinn started:2026-02-18T22:08:17Z logged:2026-02-18 #auto-dispatch pr:#1814 completed:2026-02-18
- `tea issues list` fails with `huh: could not open a new TTY: open /dev/tty: device not configured` when run from scripts/CI
Expand Down
Loading