Skip to content

fix: cron.sh script_path, unblock t1311, add t1314 for batch concurrency #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Feb 24, 2026
Merged

fix: cron.sh script_path, unblock t1311, add t1314 for batch concurrency #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/scripts/supervisor/cron.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ cmd_cron() {
done

local script_path
script_path="${_CRON_DIR}/supervisor-helper.sh"
script_path="${SCRIPT_DIR}/supervisor-helper.sh"
Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from _CRON_DIR to SCRIPT_DIR is correct as supervisor-helper.sh resides in the parent directory of the supervisor modules. However, ensure that SCRIPT_DIR is always defined as an absolute path in the main script that sources this module to prevent issues when the cron job is executed from different working directories.

References
  1. Shell script libraries should explicitly source their dependencies to ensure they are self-contained and can be sourced from any working directory.

local cron_log="${SUPERVISOR_DIR}/cron.log"

# Ensure supervisor dir exists for log file
Expand Down Expand Up @@ -302,7 +302,7 @@ cmd_watch() {
fi

local todo_file="$repo/TODO.md"
local script_path="${_CRON_DIR}/supervisor-helper.sh"
local script_path="${SCRIPT_DIR}/supervisor-helper.sh"
local watch_log="${SUPERVISOR_DIR}/watch.log"

# Platform dispatch
Expand Down
3 changes: 2 additions & 1 deletion TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ Tasks with no open blockers - ready to work on. Use `/ready` to refresh this lis
- [x] t1308 LLM observability: data collection from OpenCode plugin — extend OpenCode plugin to capture LLM request metadata via `event` hook and `tool.execute.after`. Record: model used, token counts, cost, duration, tool call counts, success/failure. Write to the SQLite DB from t1307. Incremental — each session appends, no full reparse needed. ~1h #feature #observability #opencode #auto-dispatch model:sonnet ref:GH#2177 assignee:marcusquinn started:2026-02-22T05:02:44Z status:deployed pr:#2138 completed:2026-02-22
- [x] t1309 Intent tracing in OpenCode plugin — add intent field to tool call logging. Inspired by oh-my-pi's `agent__intent` pattern where a hidden field is injected into every tool's JSON Schema requiring the LLM to describe its intent in present participle form. In our case, log the intent alongside tool calls in the observability DB (t1307) for debugging and audit trails. v1.2.7 now passes sessionID and callID to shell.env hook — more context available. Evaluate whether `tool.execute.before` hook provides enough context. ~1h #feature #auto-dispatch #observability #opencode model:sonnet ref:GH#2190 assignee:marcusquinn started:2026-02-22T16:37:42Z status:deployed pr:#2153 completed:2026-02-22
- [x] t1310 Document hashline edit format and autocorrect heuristics — create `.agents/reference/hashline-edit-format.md` documenting oh-my-pi's hashline approach: content-addressed line references (xxHash32, custom alphabet), staleness checks, and the battle-tested autocorrect heuristics (anchor echo stripping, line merge detection, wrapped line restoration, indent restoration, bottom-up edit application). This is reference material for when we build custom edit tooling for headless dispatch or the objective runner. Source: `/Users/marcusquinn/Git/oh-my-pi/packages/coding-agent/src/patch/hashline.ts`. ~1h #docs #auto-dispatch #harness #reference model:sonnet ref:GH#2191 assignee:marcusquinn started:2026-02-22T16:38:15Z status:deployed pr:#2151 completed:2026-02-22
- [ ] t1311 Evaluate oh-my-pi swarm DAG patterns for supervisor dispatch — compare oh-my-pi's YAML-defined swarm orchestration (`reports_to`/`waits_for` dependency resolution, Kahn's algorithm topological sort, execution waves) with our TODO.md `blocked-by:` system. Identify gaps: our system lacks parallel execution waves, has no `reports_to` concept, and dependency resolution is string-matching not graph-based. Propose concrete enhancements to supervisor dispatch. Source: `/Users/marcusquinn/Git/oh-my-pi/packages/swarm-extension/`. ~2h #research #orchestration #supervisor model:sonnet ref:GH#2135
- [ ] t1311 Evaluate oh-my-pi swarm DAG patterns for supervisor dispatch — compare oh-my-pi's YAML-defined swarm orchestration (`reports_to`/`waits_for` dependency resolution, Kahn's algorithm topological sort, execution waves) with our TODO.md `blocked-by:` system. Identify gaps: our system lacks parallel execution waves, has no `reports_to` concept, and dependency resolution is string-matching not graph-based. Propose concrete enhancements to supervisor dispatch. Source: `/Users/marcusquinn/Git/oh-my-pi/packages/swarm-extension/`. ~2h #research #auto-dispatch #orchestration #supervisor model:sonnet ref:GH#2135
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add the intended #auto-dispatch tag to t1311.

PR objectives say t1311 should be unblocked via #auto-dispatch, but the entry currently lacks that tag.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@TODO.md` at line 76, The TODO entry for task t1311 is missing the intended
tag; update the t1311 line in TODO.md to include the `#auto-dispatch` tag (e.g.,
append " `#auto-dispatch`" to the t1311 bullet) so the task is correctly
marked/unblocked for auto-dispatch processing; ensure you only modify the t1311
bullet and preserve the rest of the text (including other tags like
`#research/`#orchestration).


- [ ] t1314 Fix batch concurrency bypass when pulse runs without --batch flag — `cmd_pulse()` only uses batch concurrency when called with explicit `--batch <id>`. Without it, Phase 2 falls through to global dispatch with `SUPERVISOR_MAX_CONCURRENCY` (default: 4), ignoring the batch's `concurrency=1` setting. Five contributing causes: (1) no batch auto-detection in `cmd_pulse()`, (2) auto-batch absorption has no affinity checks, (3) `cmd_next()` sibling limits ignore batch concurrency, (4) `blocked-by:` not enforced in dispatch path, (5) AI lifecycle auto-merge has no human review gate. Fix: auto-detect active batches in `cmd_pulse()`, add batch affinity to auto-absorption, cap sibling limits to batch concurrency, persist `blocked-by:` in DB or re-check at dispatch time, require explicit opt-in for auto-merge. Affected files: `pulse.sh` (Phase 2), `cron.sh` (auto-pickup), `state.sh` (`cmd_next()`), `dispatch.sh` (concurrency check). ~8h (ai:6h test:2h) #bugfix #supervisor #auto-dispatch model:opus ref:GH#2163 logged:2026-02-23

- [x] t1294 Add MCPorter agent for MCP toolkit — steipete/mcporter (2K stars, MIT, TypeScript) is a runtime, CLI, and code-generation toolkit for MCP. Auto-discovers MCP servers from Cursor/Claude/Codex/Windsurf/VS Code configs, calls tools from CLI or TypeScript, generates standalone CLIs from MCP servers, emits typed TypeScript clients. Complements existing mcp-index-helper.sh (token-aware on-demand loading) and setup-mcp-integrations.sh (initial setup). Use MCPorter for ad-hoc MCP discovery, testing, CLI generation, and TypeScript automation. Create subagent doc, config template, update scripts per add-new-mcp-to-aidevops.md process. Enable for Build+, AI-DevOps agents. Links: https://github.com/steipete/mcporter https://mcporter.dev #feature #auto-dispatch #mcp #agent ~4h (ai:3h test:1h) model:sonnet ref:GH#2060 assignee:marcusquinn started:2026-02-21T08:08:00Z logged:2026-02-21 → [todo/PLANS.md#2026-02-21-mcporter-mcp-toolkit-agent] pr:#2093 completed:2026-02-21
- [x] t1294.1 Create `.agents/tools/mcp-toolkit/mcporter.md` subagent documentation — cover: install (npx/pnpm/brew), discovery (`mcporter list`), calling tools (`mcporter call`), CLI generation (`mcporter generate-cli`), typed client emission (`mcporter emit-ts`), OAuth auth (`mcporter auth`), daemon mode, ad-hoc connections, config resolution. Include AI-CONTEXT-START block with quick reference, verification prompt, supported AI assistants. ~1.5h #auto-dispatch model:opus ref:GH#2064 assignee:marcusquinn started:2026-02-21T04:06:58Z pr:#2075 completed:2026-02-21
Expand Down
Loading