Skip to content

t1263: Fix false-positive claim detection and add verified skip in auto-pickup #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Feb 19, 2026
Merged

t1263: Fix false-positive claim detection and add verified skip in auto-pickup #1979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .agents/scripts/supervisor/cron.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,10 @@ cmd_auto_pickup() {
continue
fi

# Skip tasks with assignee: or started: fields (t1062)
# These indicate someone is already working on the task
if echo "$line" | grep -qE '(assignee:|started:)'; then
# Skip tasks with assignee: or started: metadata fields (t1062, t1263)
# Match actual metadata fields, not description text containing these words.
# assignee: must be followed by a username (word chars), started: by ISO timestamp.
if echo "$line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
Copy link

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For performance and to reduce reliance on external processes, consider using bash's built-in regular expression matching instead of piping to grep. This avoids creating a subshell and invoking another process.

Suggested change
if echo "$line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
if [[ "$line" =~ (assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T) ]]; then

log_info " $task_id: already claimed or in progress — skipping auto-pickup"
continue
fi
Expand All @@ -556,7 +557,7 @@ cmd_auto_pickup() {
local existing
existing=$(db "$SUPERVISOR_DB" "SELECT status FROM tasks WHERE id = '$(sql_escape "$task_id")';" 2>/dev/null || true)
if [[ -n "$existing" ]]; then
if [[ "$existing" == "complete" || "$existing" == "cancelled" ]]; then
if [[ "$existing" == "complete" || "$existing" == "cancelled" || "$existing" == "verified" ]]; then
continue
fi
Comment on lines +560 to 562
Copy link

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and make it easier to add more statuses in the future, consider using a case statement instead of a chain of || operators.

Suggested change
if [[ "$existing" == "complete" || "$existing" == "cancelled" || "$existing" == "verified" ]]; then
continue
fi
case "$existing" in
complete|cancelled|verified) continue ;;
esac

log_info " $task_id: already tracked (status: $existing)"
Expand Down Expand Up @@ -616,9 +617,10 @@ cmd_auto_pickup() {
continue
fi

# Skip tasks with assignee: or started: fields (t1062)
# These indicate someone is already working on the task
if echo "$line" | grep -qE '(assignee:|started:)'; then
# Skip tasks with assignee: or started: metadata fields (t1062, t1263)
# Match actual metadata fields, not description text containing these words.
# assignee: must be followed by a username (word chars), started: by ISO timestamp.
if echo "$line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
Copy link

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For performance and to reduce reliance on external processes, consider using bash's built-in regular expression matching instead of piping to grep. This avoids creating a subshell and invoking another process.

Suggested change
if echo "$line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
if [[ "$line" =~ (assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T) ]]; then

log_info " $task_id: already claimed or in progress — skipping auto-pickup"
continue
fi
Expand All @@ -631,7 +633,7 @@ cmd_auto_pickup() {
local existing
existing=$(db "$SUPERVISOR_DB" "SELECT status FROM tasks WHERE id = '$(sql_escape "$task_id")';" 2>/dev/null || true)
if [[ -n "$existing" ]]; then
if [[ "$existing" == "complete" || "$existing" == "cancelled" ]]; then
if [[ "$existing" == "complete" || "$existing" == "cancelled" || "$existing" == "verified" ]]; then
continue
fi
Comment on lines +636 to 638
Copy link

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and make it easier to add more statuses in the future, consider using a case statement instead of a chain of || operators.

Suggested change
if [[ "$existing" == "complete" || "$existing" == "cancelled" || "$existing" == "verified" ]]; then
continue
fi
case "$existing" in
complete|cancelled|verified) continue ;;
esac

log_info " $task_id: already tracked (status: $existing)"
Expand Down Expand Up @@ -764,8 +766,8 @@ cmd_auto_pickup() {
continue
fi

# Skip tasks with assignee: or started: fields
if echo "$sub_line" | grep -qE '(assignee:|started:)'; then
# Skip tasks with assignee: or started: metadata fields (t1263)
if echo "$sub_line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
Copy link

@gemini-code-assist gemini-code-assist bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For performance and to reduce reliance on external processes, consider using bash's built-in regular expression matching instead of piping to grep. This avoids creating a subshell and invoking another process.

Suggested change
if echo "$sub_line" | grep -qE '(assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T)'; then
if [[ "$sub_line" =~ (assignee:[a-zA-Z0-9_-]+|started:[0-9]{4}-[0-9]{2}-[0-9]{2}T) ]]; then

log_info " $sub_id: already claimed or in progress — skipping subtask pickup"
continue
fi
Expand Down
Loading