-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: remove serper MCP, use curl subagent instead #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,14 +41,14 @@ get_mcp_command() { | |
| "stagehand-python") echo "${HOME}/.aidevops/stagehand-python/.venv/bin/python ${HOME}/.aidevops/stagehand-python/examples/basic_example.py" ;; | ||
| "stagehand-both") echo "both" ;; | ||
| "dataforseo") echo "npx dataforseo-mcp-server" ;; | ||
| "serper") echo "uv tool run serper-mcp-server" ;; | ||
| # serper - REMOVED: Uses curl subagent (.agent/seo/serper.md), no MCP needed | ||
| *) echo "" ;; | ||
| esac | ||
| return 0 | ||
| } | ||
|
|
||
| # Available integrations list | ||
| MCP_LIST="chrome-devtools playwright cloudflare-browser ahrefs perplexity nextjs-devtools google-search-console pagespeed-insights grep-vercel claude-code-mcp stagehand stagehand-python stagehand-both dataforseo serper" | ||
| MCP_LIST="chrome-devtools playwright cloudflare-browser ahrefs perplexity nextjs-devtools google-search-console pagespeed-insights grep-vercel claude-code-mcp stagehand stagehand-python stagehand-both dataforseo" | ||
|
|
||
| # Check prerequisites | ||
| check_prerequisites() { | ||
|
|
@@ -278,34 +278,8 @@ install_mcp() { | |
| print_info "Available modules: SERP, KEYWORDS_DATA, BACKLINKS, ONPAGE, DATAFORSEO_LABS, BUSINESS_DATA, DOMAIN_ANALYTICS, CONTENT_ANALYSIS, AI_OPTIMIZATION" | ||
| print_info "Docs: https://docs.dataforseo.com/v3/" | ||
| ;; | ||
| "serper") | ||
| print_info "Setting up Serper MCP for Google Search API..." | ||
| print_warning "Serper MCP requires API key" | ||
| print_info "Get API key from: https://serper.dev/" | ||
| print_info "" | ||
| print_info "Store in ~/.config/aidevops/mcp-env.sh:" | ||
| print_info " export SERPER_API_KEY=\"your_api_key\"" | ||
| print_info "" | ||
| print_info "Or use the helper script:" | ||
| print_info " bash ~/.aidevops/agents/scripts/setup-local-api-keys.sh set SERPER_API_KEY your_key" | ||
| print_info "" | ||
| print_info "For OpenCode, use bash wrapper pattern in opencode.json:" | ||
| print_info ' "serper": {' | ||
| print_info ' "type": "local",' | ||
| print_info ' "command": ["/bin/bash", "-c", "source ~/.config/aidevops/mcp-env.sh && SERPER_API_KEY=\$SERPER_API_KEY uv tool run serper-mcp-server"],' | ||
| print_info ' "enabled": true' | ||
| print_info ' }' | ||
| print_info "" | ||
| print_info "Available tools: google_search, google_search_images, google_search_videos, google_search_places, google_search_maps, google_search_reviews, google_search_news, google_search_shopping, google_search_lens, google_search_scholar, google_search_patents, google_search_autocomplete, webpage_scrape" | ||
| print_info "GitHub: https://github.com/garylab/serper-mcp-server" | ||
|
|
||
| # Check if uv is installed and supports 'tool' subcommand | ||
| if ! command -v uv &> /dev/null || ! uv tool --help &> /dev/null; then | ||
| print_warning "uv (Python package manager) not found or too old" | ||
| print_info "Install/update with: curl -LsSf https://astral.sh/uv/install.sh | sh" | ||
| print_info "Alternative: pip install serper-mcp-server" | ||
| fi | ||
| ;; | ||
| # "serper" - REMOVED: Uses curl subagent (.agent/seo/serper.md), no MCP needed | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| # Get API key from https://serper.dev/ and set SERPER_API_KEY in mcp-env.sh | ||
| *) | ||
| print_error "Unknown MCP integration: $mcp_name" | ||
| print_info "Available integrations: $MCP_LIST" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and maintainability, consider defining
MCP_LISTas a bash array instead of a long, space-separated string. This makes it easier to add, remove, or view items in the list.You would need to update how this variable is used in loops and for printing, for example, by iterating with
for mcp in "${MCP_LIST[@]}"and printing withecho "${MCP_LIST[*]}".