t1189: Fix AI actions pipeline empty-response handling to prevent rc=1 cascade#1807
t1189: Fix AI actions pipeline empty-response handling to prevent rc=1 cascade#1807marcusquinn merged 1 commit intomainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When the AI model returns an empty or non-parseable response, the pipeline previously returned rc=1 causing false-positive errors in the pulse cycle. This occurred 6+ times on 2026-02-18 between 15:53-19:15. Changes: - ai-reason.sh: unparseable AI response now returns [] + rc=0 (was error + rc=1) - ai-actions.sh: non-array plan_type now returns empty result + rc=0 (was rc=1) - Both paths log a warning so the issue is still visible in logs - Added test 2.3b to verify pipeline rc=0 on non-JSON AI response Chose to treat non-JSON as 'no actions' rather than error — matches existing empty-response handling at line 272 and aligns with t1182 precedent.
5737583 to
238941b
Compare
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Feb 18 22:13:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|



Summary
[]rather than a pipeline errorai-reason.shandai-actions.shnow returnrc=0withexecuted=0when the AI response is unparseablelog_warnis still emitted so the issue remains visible in logs without causing false-positive pipeline errorsRoot Cause
When the AI model returns plain text or an empty response (observed 6+ times on 2026-02-18 between 15:53-19:15),
extract_action_planreturns empty, causingrun_ai_reasoningto returnrc=1. This propagated throughrun_ai_actions_pipelineas a pipeline error, generating noise in self-reflection analysis.Changes
ai-reason.sh: Unparseable AI response now outputs[]+return 0(was{"error":"no_action_plan",...}+return 1)ai-actions.sh: Non-arrayplan_type(including empty string from failed jq parse) now outputs{"executed":0,...}+return 0(was{"error":"invalid_plan_type",...}+return 1)tests/test-ai-supervisor-e2e.sh: Added Test 2.3b verifying pipeline returnsrc=0withexecuted=0when AI returns non-JSON textVerification
Ref #1798