Skip to content

t1085.3: AI supervisor action executor with validated action types #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 4 commits into from
Feb 18, 2026
Merged

t1085.3: AI supervisor action executor with validated action types #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88d0da2
feat: add AI supervisor action executor module (t1085.3)
marcusquinn Feb 18, 2026
f3301d0
feat: wire ai-actions module into supervisor-helper.sh (t1085.3)
marcusquinn Feb 18, 2026
16528d4
test: add unit tests for AI action executor (t1085.3)
marcusquinn Feb 18, 2026
d7956e4
fix: add shellcheck disable directives to test file (t1085.3)
marcusquinn Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion .agents/scripts/supervisor-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ source "${SUPERVISOR_MODULE_DIR}/memory-integration.sh"
source "${SUPERVISOR_MODULE_DIR}/todo-sync.sh"
source "${SUPERVISOR_MODULE_DIR}/ai-context.sh"
source "${SUPERVISOR_MODULE_DIR}/ai-reason.sh"
source "${SUPERVISOR_MODULE_DIR}/ai-actions.sh"

# Valid states for the state machine
# shellcheck disable=SC2034 # Used by supervisor/state.sh
Expand Down Expand Up @@ -691,16 +692,55 @@ main() {
contest) cmd_contest "$@" ;;
ai-context) build_ai_context "${REPO_PATH:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}" "${1:-full}" ;;
ai-reason) run_ai_reasoning "${REPO_PATH:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}" "${1:-full}" ;;
ai-actions)
# Execute an action plan: supervisor-helper.sh ai-actions [--mode execute|dry-run|validate-only] --plan '<json>'
local _aa_mode="execute" _aa_plan="" _aa_repo=""
_aa_repo="${REPO_PATH:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}"
while [[ $# -gt 0 ]]; do
case "$1" in
--mode)
_aa_mode="$2"
shift 2
;;
--plan)
_aa_plan="$2"
shift 2
;;
--dry-run)
_aa_mode="dry-run"
shift
;;
--repo)
_aa_repo="$2"
shift 2
;;
*) shift ;;
esac
done
Comment on lines +699 to +719
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The argument parsing loop for the ai-actions command uses shift 2 for options that take a value. This is fragile and will fail with an error if an option is passed without its value or as the last argument (e.g., ... --mode). It's safer to check for the presence of $2 before shifting and to handle the missing argument case gracefully.

                while [[ $# -gt 0 ]]; do
                        case "$1" in
                        --mode)
                                if [[ -z "$2" || "$2" == --* ]]; then
                                        log_error "ai-actions: --mode requires an argument"
                                        return 1
                                fi
                                _aa_mode="$2"
                                shift 2
                                ;;
                        --plan)
                                if [[ -z "$2" || "$2" == --* ]]; then
                                        log_error "ai-actions: --plan requires an argument"
                                        return 1
                                fi
                                _aa_plan="$2"
                                shift 2
                                ;;
                        --dry-run)
                                _aa_mode="dry-run"
                                shift
                                ;;
                        --repo)
                                if [[ -z "$2" || "$2" == --* ]]; then
                                        log_error "ai-actions: --repo requires an argument"
                                        return 1
                                fi
                                _aa_repo="$2"
                                shift 2
                                ;;
                        *) shift ;;
                        esac
                done

if [[ -z "$_aa_plan" ]]; then
log_error "ai-actions requires --plan '<json>'"
return 1
fi
execute_action_plan "$_aa_plan" "$_aa_repo" "$_aa_mode"
;;
ai-pipeline)
# Run full reasoning + action execution: supervisor-helper.sh ai-pipeline [full|dry-run]
run_ai_actions_pipeline "${REPO_PATH:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}" "${1:-full}"
;;
ai-status)
local last_run_ts
last_run_ts=$(db "$SUPERVISOR_DB" "SELECT MAX(timestamp) FROM state_log WHERE task_id = 'ai-supervisor' AND to_state = 'complete';" 2>/dev/null || echo "never")
local run_count
run_count=$(db "$SUPERVISOR_DB" "SELECT COUNT(*) FROM state_log WHERE task_id = 'ai-supervisor' AND to_state = 'complete';" 2>/dev/null || echo 0)
local action_count
action_count=$(db "$SUPERVISOR_DB" "SELECT COUNT(*) FROM state_log WHERE task_id = 'ai-supervisor' AND from_state = 'actions';" 2>/dev/null || echo 0)
echo "AI Supervisor Status"
echo " Last run: ${last_run_ts:-never}"
echo " Total runs: $run_count"
echo " Total reasoning runs: $run_count"
echo " Total action executions: $action_count"
echo " Enabled: ${SUPERVISOR_AI_ENABLED:-true}"
echo " Interval: ${SUPERVISOR_AI_INTERVAL:-15} pulses (~$((${SUPERVISOR_AI_INTERVAL:-15} * 2))min)"
echo " Max actions/cycle: ${AI_MAX_ACTIONS_PER_CYCLE:-10}"
echo " Log dir: ${AI_REASON_LOG_DIR:-$HOME/.aidevops/logs/ai-supervisor}"
;;
help | --help | -h) show_usage ;;
Expand Down
Loading
Loading