t1053: Auto-generate VERIFY.md entries during deploy phase#1497
t1053: Auto-generate VERIFY.md entries during deploy phase#1497marcusquinn merged 2 commits intomainfrom
Conversation
Consolidate verify entry generation into generate_verify_entry() called from cmd_transition when tasks reach deployed state. Improvements: - Fix description truncation (was only first word, now full 60-char) - Add subagent-index checks for .agents/ tool/service/workflow files - Add .toon/.yml/.yaml/.json file type handling - Filter out planning files (TODO.md, todo/*, .task-counter) - Single gh pr view call (was calling twice) - Fix commit: use new commit_and_push_verify() for todo/VERIFY.md (was incorrectly calling commit_and_push_todo which only handles TODO.md) - Graceful fallback when VERIFY-QUEUE-END marker missing (append to end) - Remove duplicate populate_verify_queue calls from deploy.sh (cmd_transition already triggers generate_verify_entry)
|
Caution Review failedThe pull request is closed. WalkthroughThe changes refactor VERIFY.md queue population to rely on auto-generation during deployment. The deploy.sh removes explicit populate_verify_queue calls, while todo-sync.sh adds a commit_and_push_verify helper and enhances generate_verify_entry to handle PR files, exclude planning files, and manage VERIFY.md entries with improved marker handling and push logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sun Feb 15 19:27:00 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the automated generation of Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the generation of VERIFY.md entries, centralizing the logic and fixing several bugs. The changes are a good improvement, removing duplicate code from deploy.sh and making generate_verify_entry in todo-sync.sh more robust.
However, I've identified a few critical regressions in the refactored generate_verify_entry function where important verification checks have been accidentally removed. I've also noted a couple of style guide violations. Please see my detailed comments for suggestions on how to address these issues.
| local repo_path="$1" | ||
| local commit_msg="$2" | ||
| local max_retries="${3:-3}" |
There was a problem hiding this comment.
The repository style guide (line 11) requires declaring and assigning variables from function arguments separately to ensure exit code safety (e.g., local var; var="$1"). These lines combine declaration and assignment. Please update them to follow the guide.
| local repo_path="$1" | |
| local commit_msg="$2" | |
| local max_retries="${3:-3}" | |
| local repo_path | |
| repo_path="$1" | |
| local commit_msg | |
| commit_msg="$2" | |
| local max_retries | |
| max_retries="${3:-3}" |
References
- Function arguments should be assigned to local variables in two steps (declaration, then assignment) to avoid issues with
set -eif the assignment command fails. (link)
| files_list=$(gh pr view "$pr_number" --repo "$repo_slug" --json files --jq '.files[].path' 2>/dev/null | tr '\n' ', ' | sed 's/,$//') | ||
| # Single gh call — store result for both file list and check generation | ||
| local pr_files_raw="" | ||
| pr_files_raw=$(gh pr view "$pr_number" --repo "$repo_slug" --json files --jq '.files[].path' 2>/dev/null || echo "") |
There was a problem hiding this comment.
This line uses 2>/dev/null to suppress errors from the gh pr view command. The repository style guide (line 50) states that 2>/dev/null is only acceptable when redirecting to log files, not for blanket suppression. Please redirect stderr to the supervisor log file ($SUPERVISOR_LOG) to ensure that any errors from the gh command are captured for debugging.
| pr_files_raw=$(gh pr view "$pr_number" --repo "$repo_slug" --json files --jq '.files[].path' 2>/dev/null || echo "") | |
| pr_files_raw=$(gh pr view "$pr_number" --repo "$repo_slug" --json files --jq '.files[].path' 2>>"$SUPERVISOR_LOG" || echo "") |
References
- Blanket error suppression with
2>/dev/nullis not allowed. Errors should be redirected to log files. (link)
1 participant
Summary
generate_verify_entry()function called fromcmd_transitionwhen tasks reachdeployedstatepopulate_verify_queuecalls from deploy.sh sincecmd_transitionalready triggers entry generationChanges
todo-sync.shcommit_and_push_verify()— dedicated commit/push fortodo/VERIFY.mdwith pull-rebase retry (mirrorscommit_and_push_todo)generate_verify_entry()— complete rewrite:${tdesc%% *}= first word only)gh pr viewcall (was calling twice).agents/tools|services|workflows/*.mdfiles.toon,.yml,.yaml,.jsonfile typescommit_and_push_verify()instead ofcommit_and_push_todo()deploy.shpopulate_verify_queuecalls from both the normal deploy path and the stuck-deploying recovery pathcmd_transition("deployed")instate.shalready callsgenerate_verify_entry()— the explicit calls were creating duplicate entriesTesting
Ref #1496
Summary by CodeRabbit