Skip to content

fix: Phase 3b2 and triage gh pr view fails from cron (missing --repo) #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusquinn merged 1 commit into from
Feb 15, 2026
Merged

fix: Phase 3b2 and triage gh pr view fails from cron (missing --repo) #1490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .agents/scripts/supervisor/pulse.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,10 +557,11 @@ cmd_pulse() {
while IFS='|' read -r stale_id stale_status stale_pr _stale_repo; do
[[ -z "$stale_id" ]] && continue

# Extract PR number from URL
local pr_number=""
if [[ "$stale_pr" =~ /pull/([0-9]+)$ ]]; then
pr_number="${BASH_REMATCH[1]}"
# Extract PR number and repo slug from URL
local pr_number="" pr_repo_slug=""
if [[ "$stale_pr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)$ ]]; then

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex anchor $ is quite strict. If the PR URL contains a trailing slash or query parameters (e.g., from a browser copy-paste), this match will fail. Consider making the end of the regex more flexible to handle these common cases.

Suggested change
if [[ "$stale_pr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)$ ]]; then
if [[ "$stale_pr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)(/|\?|#|$) ]]; then

pr_repo_slug="${BASH_REMATCH[1]}"
pr_number="${BASH_REMATCH[2]}"
fi
if [[ -z "$pr_number" ]]; then
# Non-standard PR URL or obsolete marker — mark as cancelled
Expand All @@ -570,9 +571,9 @@ cmd_pulse() {
continue
fi

# Query GitHub for actual PR state
# Query GitHub for actual PR state (use --repo for cron compatibility)
local pr_json
pr_json=$(gh pr view "$pr_number" --json state,mergedAt 2>/dev/null || echo "")
pr_json=$(gh pr view "$pr_number" --repo "$pr_repo_slug" --json state,mergedAt 2>/dev/null || echo "")
if [[ -z "$pr_json" ]]; then
log_warn " Phase 3b2: $stale_id PR #$pr_number unreachable — skipping"
continue
Expand Down Expand Up @@ -1945,19 +1946,20 @@ cmd_triage() {
continue
fi

# Extract PR number
local pr_num=""
if [[ "$tpr" =~ /pull/([0-9]+)$ ]]; then
pr_num="${BASH_REMATCH[1]}"
# Extract PR number and repo slug from URL
local pr_num="" triage_repo_slug=""
if [[ "$tpr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)$ ]]; then

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the change in cmd_pulse, the strict $ anchor might cause parsing failures for URLs with trailing slashes or parameters. Using a more permissive termination pattern would improve robustness.

Suggested change
if [[ "$tpr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)$ ]]; then
if [[ "$tpr" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+)(/|\?|#|$) ]]; then

triage_repo_slug="${BASH_REMATCH[1]}"
pr_num="${BASH_REMATCH[2]}"
fi
if [[ -z "$pr_num" ]]; then
cat_obsolete="${cat_obsolete}${tid}|${tstatus}|unparseable:${tpr}\n"
continue
fi

# Query GitHub
# Query GitHub (use --repo for cron compatibility)
local pr_json
pr_json=$(gh pr view "$pr_num" --json state,mergedAt 2>/dev/null || echo "")
pr_json=$(gh pr view "$pr_num" --repo "$triage_repo_slug" --json state,mergedAt 2>/dev/null || echo "")
if [[ -z "$pr_json" ]]; then
cat_no_pr="${cat_no_pr}${tid}|${tstatus}|PR #${pr_num} unreachable\n"
continue
Expand Down
Loading