t1004: Ensure all task completion paths write pr:#NNN to TODO.md by marcusquinn · Pull Request #1295 · marcusquinn/aidevops

marcusquinn · 2026-02-12T20:43:24Z

Summary

Ensures every code path that marks tasks [x] in TODO.md also writes proof-log evidence (pr:#NNN or verified:YYYY-MM-DD). This prevents false completion cascades in issue-sync and satisfies pre-commit hook enforcement.

Changes

Gap 1: `version-manager.sh` `auto_mark_tasks_complete()` (primary fix)

Added find_pr_for_task_from_commits() — discovers PR numbers from commit messages ((#NNN) pattern) with gh pr list fallback
Modified auto_mark_tasks_complete() to write pr:#NNN when a PR is found, or verified:YYYY-MM-DD as fallback (release itself is verification)

Gap 2: `supervisor/todo-sync.sh` `update_todo_on_complete()` (fallback fix)

Added verified:YYYY-MM-DD fallback when no PR URL is parseable (e.g., diagnostic tasks that skip verify_task_deliverables())
Prior worker (2eccc32) added pr:#NNN extraction; this commit adds the verified: else-branch

Gap 3: `issue-sync-helper.sh` `cmd_close()` (prior worker — `03c551a`)

Reordered find_closing_pr() to run BEFORE evidence check (chicken-and-egg fix)
Backfills pr:#NNN to TODO.md before checking for evidence, so the check passes

Verification

ShellCheck: zero violations on all modified files
Bash syntax: validated
PR extraction regex tested against real commit messages including edge cases

Ref #1285

Summary by CodeRabbit

Bug Fixes
- Task completion tracking now consistently records verification metadata, including timestamp information when pull requests are not directly associated with completed tasks.
Style
- Resolved formatting, indentation, and alignment inconsistencies across related management scripts to improve code readability and overall consistency.

gemini-code-assist · 2026-02-12T20:43:27Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

coderabbitai · 2026-02-12T20:43:41Z

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies task completion logic in the supervisor script to always record proof information—using PR references when available or verification dates as fallback—and reformats the version manager script with whitespace and indentation adjustments.

Changes

Cohort / File(s)	Summary
Task Completion Auditing `.agents/scripts/supervisor/todo-sync.sh`	Modified `update_todo_on_complete` to always append proof metadata (either `pr:`#NNN`` or `verified:<date>`) when marking tasks complete, changing the observable outcome for tasks without associated PRs.
Code Formatting `.agents/scripts/version-manager.sh`	Whitespace, indentation, and line-rewrap adjustments across the script; no functional or control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

#1258: Adds end-to-end tests validating update_todo_on_complete behavior and proof-log field presence (pr:# and verified:).
#944: Implements the same completion-audit pattern of appending PR references or verified date fallback for task completion.
#1220: Directly modifies the same update_todo_on_complete function in supervisor todo-sync logic.

Poem

🎯 Todo tasks now tell their tale,
With proof attached—they shall not fail,
A PR link or date so true,
Each proof recorded, forever in view,
While formats gleam with spacing bright,
Zero debt maintained—all A-grade right! ✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/t1004

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…g (t1004) Previously, auto_mark_tasks_complete() marked tasks [x] with completed: but never wrote pr:#NNN or verified: proof-log. This violated the proof-log requirement enforced by pre-commit hooks and issue-sync. Added find_pr_for_task_from_commits() to discover PR numbers from commit messages (#NNN pattern) with gh CLI fallback. Falls back to verified:date when no PR is discoverable (release itself is verification).

…RL (t1004) When diagnostic tasks or tasks without a parseable PR URL pass verify_task_deliverables(), the proof_log was empty — resulting in [x] lines without pr:#NNN or verified: evidence. Now falls back to verified:YYYY-MM-DD when no PR number is extractable.

Bash regex with literal parentheses in =~ is unreliable across bash versions. Switched to grep -oE for robust PR number extraction from commit messages.

github-actions · 2026-02-12T20:44:38Z

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 0 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Thu Feb 12 20:44:35 UTC 2026: Code review monitoring started
Thu Feb 12 20:44:35 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 0

📈 Current Quality Metrics

BUGS: 0
CODE SMELLS: 0
VULNERABILITIES: 0

Generated on: Thu Feb 12 20:44:37 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

sonarqubecloud · 2026-02-12T20:45:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

marcusquinn added 3 commits February 12, 2026 20:44

fix: use grep instead of bash regex for PR number extraction (t1004)

d02121a

Bash regex with literal parentheses in =~ is unreliable across bash versions. Switched to grep -oE for robust PR number extraction from commit messages.

marcusquinn force-pushed the feature/t1004 branch from 94f1ab2 to d02121a Compare February 12, 2026 20:44

marcusquinn merged commit ede2f93 into main Feb 12, 2026
10 of 11 checks passed

marcusquinn deleted the feature/t1004 branch February 12, 2026 20:46

marcusquinn added a commit that referenced this pull request Feb 12, 2026

chore: mark t1004 complete in TODO.md (#1295)

cb1dbdf

marcusquinn mentioned this pull request Feb 12, 2026

[Supervisor:marcusquinn] 0 queued, 1 working at 19:50 UTC #1314

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

t1004: Ensure all task completion paths write pr:#NNN to TODO.md#1295

t1004: Ensure all task completion paths write pr:#NNN to TODO.md#1295
marcusquinn merged 3 commits intomainfrom
feature/t1004

marcusquinn commented Feb 12, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

gemini-code-assist bot commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026 •

edited

Loading

Review failed

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

sonarqubecloud bot commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

marcusquinn commented Feb 12, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Gap 1: version-manager.sh auto_mark_tasks_complete() (primary fix)

Gap 2: supervisor/todo-sync.sh update_todo_on_complete() (fallback fix)

Gap 3: issue-sync-helper.sh cmd_close() (prior worker — 03c551a)

Verification

Summary by CodeRabbit

Uh oh!

gemini-code-assist bot commented Feb 12, 2026

Uh oh!

coderabbitai bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions bot commented Feb 12, 2026

🔍 Code Quality Report

📈 Current Quality Metrics

Uh oh!

sonarqubecloud bot commented Feb 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

marcusquinn commented Feb 12, 2026 •

edited by coderabbitai bot

Loading

Gap 1: `version-manager.sh` `auto_mark_tasks_complete()` (primary fix)

Gap 2: `supervisor/todo-sync.sh` `update_todo_on_complete()` (fallback fix)

Gap 3: `issue-sync-helper.sh` `cmd_close()` (prior worker — `03c551a`)

coderabbitai bot commented Feb 12, 2026 •

edited

Loading