Skip to content

Comments

t317.3: Update AGENTS.md task completion rules#1250

Merged
marcusquinn merged 1 commit intomainfrom
feature/t317.3
Feb 12, 2026
Merged

t317.3: Update AGENTS.md task completion rules#1250
marcusquinn merged 1 commit intomainfrom
feature/t317.3

Conversation

@marcusquinn
Copy link
Owner

Summary

  • Add instruction for interactive sessions to use complete_task() or manually add pr:#NNN/verified:YYYY-MM-DD before marking tasks [x]
  • Document pre-commit hook enforcement via validate_todo_completions()
  • Clarify that pre-commit warning is non-blocking but serves as a reminder to add completion evidence

Changes

  • Updated "Task completion rules" section in .agents/AGENTS.md
  • Added two new bullet points explaining interactive session requirements and pre-commit enforcement

Testing

  • Verified markdown formatting with markdownlint
  • Reviewed diff to ensure clarity and accuracy

Ref #1231

@gemini-code-assist
Copy link

Summary of Changes

Hello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity and robustness of task completion rules within the AGENTS.md documentation. It aims to prevent premature or unverified task completions by providing explicit instructions for interactive sessions and integrating a pre-commit hook to remind users about necessary evidence, thereby reinforcing the integrity of the task tracking system.

Highlights

  • Interactive Session Guidelines: Added explicit instructions for interactive sessions, requiring the use of complete_task() or manual addition of pr:#NNN or verified:YYYY-MM-DD to a task line before marking it as complete [x].
  • Pre-commit Hook Documentation: Documented the validate_todo_completions() pre-commit hook, explaining its role in checking for completion evidence when tasks are marked [x].
  • Pre-commit Warning Clarification: Clarified that the pre-commit hook's warning for missing completion evidence is non-blocking, serving as a reminder rather than preventing the commit.
Changelog
  • .agents/AGENTS.md
    • Introduced a new rule for interactive sessions, detailing how to add pr:#NNN or verified:YYYY-MM-DD before marking tasks as complete.
    • Added a section explaining the pre-commit hook's role in validating TODO completions and its non-blocking warning mechanism.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 15 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Thu Feb 12 13:46:57 UTC 2026: Code review monitoring started
Thu Feb 12 13:46:57 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 15

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 15
  • VULNERABILITIES: 0

Generated on: Thu Feb 12 13:47:00 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the AGENTS.md file to clarify task completion rules, specifically for interactive sessions and pre-commit hook enforcement. The changes provide better guidance on how to mark tasks as complete, ensuring that proper evidence (PR number or verified date) is included. This improves the auditability and reliability of task tracking within the project.

- Add instruction for interactive sessions to use complete_task() or manually add pr:#/verified: before marking [x]
- Document pre-commit hook enforcement via validate_todo_completions()
- Clarify that pre-commit warning is non-blocking but serves as reminder
- Ref GH#1231
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/t317.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 15 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Thu Feb 12 13:56:03 UTC 2026: Code review monitoring started
Thu Feb 12 13:56:04 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 15

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 15
  • VULNERABILITIES: 0

Generated on: Thu Feb 12 13:56:06 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link

marcusquinn added a commit that referenced this pull request Feb 12, 2026
- Comprehensive test suite validating all proof-log enforcement paths
- Tests pre-commit hook (t317.1), complete_task() (t317.2), AGENTS.md (t317.3)
- Validates supervisor verification and issue-sync integration
- All 21 tests passing (100%)
- Static analysis approach for non-destructive testing
- Detailed test report with recommendations

Test results:
✓ Pre-commit hook enforces pr:# or verified: fields (4/4)
✓ complete_task() helper fully functional (7/7 - MERGED)
✓ AGENTS.md documentation complete (3/3)
✓ Supervisor verification logic present (2/2)
✓ Issue-sync proof-log aware (3/3)
✓ Consistent field naming across components (2/2)

Status: All components ready for production
Blockers: None - PRs #1249 and #1250 ready to merge

Ref #1232
@marcusquinn marcusquinn merged commit f9f5f75 into main Feb 12, 2026
11 checks passed
marcusquinn added a commit that referenced this pull request Feb 12, 2026
- Comprehensive test suite validating all proof-log enforcement paths
- Tests pre-commit hook (t317.1), complete_task() (t317.2), AGENTS.md (t317.3)
- Validates supervisor verification and issue-sync integration
- All 21 tests passing (100%)
- Static analysis approach for non-destructive testing
- Detailed test report with recommendations

Test results:
✓ Pre-commit hook enforces pr:# or verified: fields (4/4)
✓ complete_task() helper fully functional (7/7 - MERGED)
✓ AGENTS.md documentation complete (3/3)
✓ Supervisor verification logic present (2/2)
✓ Issue-sync proof-log aware (3/3)
✓ Consistent field naming across components (2/2)

Status: All components ready for production
Blockers: None - PRs #1249 and #1250 ready to merge

Ref #1232
@marcusquinn marcusquinn deleted the feature/t317.3 branch February 12, 2026 14:07
alex-solovyev pushed a commit that referenced this pull request Feb 12, 2026
* test: should fail without proof-log

* test(t317.4): Add end-to-end proof-log system validation

- Comprehensive test suite validating all proof-log enforcement paths
- Tests pre-commit hook (t317.1), complete_task() (t317.2), AGENTS.md (t317.3)
- Validates supervisor verification and issue-sync integration
- All 21 tests passing (100%)
- Static analysis approach for non-destructive testing
- Detailed test report with recommendations

Test results:
✓ Pre-commit hook enforces pr:# or verified: fields (4/4)
✓ complete_task() helper fully functional (7/7 - MERGED)
✓ AGENTS.md documentation complete (3/3)
✓ Supervisor verification logic present (2/2)
✓ Issue-sync proof-log aware (3/3)
✓ Consistent field naming across components (2/2)

Status: All components ready for production
Blockers: None - PRs #1249 and #1250 ready to merge

Ref #1232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant