refactor: elevate mcp_glob warning to MANDATORY section #125
Conversation
- Add new '🛑 MANDATORY: File Discovery' section after git check - Same prominence as Pre-Edit Git Check with failure = bug language - Remove duplicate content from Quick Reference section - Update Critical Rules to reference new section This addresses compliance issues where mcp_glob was used despite Bash alternatives being available. The elevated positioning should improve adherence to the file discovery guidelines.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe PR restructures file-discovery guidance in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the documentation for AI agents by elevating the warning against using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🤖 Augment PR SummarySummary: This PR strengthens agent guidance around file discovery by elevating the existing Changes:
Technical Notes: Emphasizes Bash-based alternatives as the default because they are faster and typically respect ignore rules, reserving 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the agent guidelines to elevate the warning against using mcp_glob into a new mandatory section. The change is well-motivated, clearly written, and successfully emphasizes the use of more performant alternatives for file discovery. My review includes one suggestion to make the command examples more generic, which should improve their interpretation by AI agents and prevent incorrect tool usage.
.agent/AGENTS.md
Outdated
| | Git-tracked files | `git ls-files '*.md'` | Instant, most common case | | ||
| | Untracked/system files | `fd -e md` or `fd -g '*.md'` | Fast, respects .gitignore | | ||
| | Content + file list | `rg --files -g '*.md'` | Fast, respects .gitignore | |
There was a problem hiding this comment.
The command examples in the table are specific to Markdown files ('*.md' and -e md). While this is a good concrete example, it might be beneficial to use more generic placeholders. This will help ensure an AI agent understands the commands apply to any file type and doesn't mistakenly fall back to mcp_glob for non-Markdown files.
| | Git-tracked files | `git ls-files '*.md'` | Instant, most common case | | |
| | Untracked/system files | `fd -e md` or `fd -g '*.md'` | Fast, respects .gitignore | | |
| | Content + file list | `rg --files -g '*.md'` | Fast, respects .gitignore | | |
| | Git-tracked files | `git ls-files '<pattern>'` | Instant, most common case | | |
| | Untracked/system files | `fd -e <ext>` or `fd -g '<pattern>'` | Fast, respects .gitignore | | |
| | Content + file list | `rg --files -g '<pattern>'` | Fast, respects .gitignore | |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sun Jan 18 21:05:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Address review feedback from gemini-code-assist: use <pattern> and <ext> placeholders instead of specific '*.md' examples to ensure AI agents understand the commands apply to any file type.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sun Jan 18 21:09:06 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
1 participant
Summary
🛑 MANDATORY: File Discoverysection after the git check sectionMotivation
During a session,
mcp_globwas used twice when Bash alternatives (git ls-files,fd) were available. The existing instruction was in Quick Reference but wasn't being followed consistently.Elevating to MANDATORY section with the same weight as the git check should improve compliance.
Changes
.agent/AGENTS.md: +22/-23 lines (net -1 line due to deduplication)Testing
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.