-
Notifications
You must be signed in to change notification settings - Fork 6
docs: add explicit PR-required rule for all non-planning changes (t297) #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a clear instruction that every change to scripts, agents, configs, or workflows MUST go through worktree + PR + CI — no matter how small. Prevents rationalizing direct-to-main pushes for 'trivial' changes.
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request formalizes and strengthens the development workflow by explicitly mandating that all code and configuration changes, no matter how minor, must undergo a full review and continuous integration process via a pull request. This aims to ensure consistent quality, prevent accidental regressions, and maintain the integrity of the main branch by eliminating ambiguity around when a PR is required. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis PR adds policy documentation to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Feb 11 22:11:21 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a crucial documentation update to AGENTS.md, explicitly mandating that all non-planning code changes must go through a pull request and CI pipeline. The change is well-written, clear, and directly addresses a recent incident where a change was pushed to main without review. By formalizing this rule and listing the explicit exceptions, it significantly strengthens the development workflow and prevents regressions. The change is excellent and I have no further recommendations.



Summary
TODO.md,todo/,VERIFY.mdContext
The auto-dispatch label removal (issue-sync-helper.sh, 5 lines deleted) was pushed directly to main without PR/CI. The existing rule said "planning-only files go direct to main" but didn't explicitly state the inverse — that all other changes require a PR. This made it easy to rationalize skipping CI for "trivial" changes.
Changes
.agents/AGENTS.mdSummary by CodeRabbit