t247: Reduce clean_exit_no_signal retries#1038
Merged
marcusquinn merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Feb 11 00:47:01 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
marcusquinn
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Reduces
clean_exit_no_signalretries through three coordinated improvements that prevent context exhaustion, preserve worker output, and eliminate unnecessary retries. This meta-task combines t247.1 and t247.2 to address the root cause of 16 retry incidents (100% eventually succeeded, but each retry wasted ~300s).Problem
Workers that exhaust their context window exit cleanly (EXIT:0) without emitting completion signals. The supervisor sees:
FULL_LOOP_COMPLETEorTASK_COMPLETEsignalResult:
retry:clean_exit_no_signal→ full re-dispatch → ~300s wasted per retry.Solution (Three-Tier Defense)
1. Context-Remaining Guard (t247.1 - PR #987)
Location:
.agents/scripts/loop-common.sh,ralph-loop-helper.shMechanism: Proactive detection before context exhaustion:
Action: When triggered:
loop_emergency_push()— Commits and pushes any uncommitted workloop_emit_completion_signal()— Emits<promise>FULL_LOOP_COMPLETE</promise>to stdoutResult: Worker signals completion before dying, supervisor sees
FULL_LOOP_COMPLETE→ no retry.2. Supervisor Auto-PR Creation (t247.2 - PR #988)
Location:
.agents/scripts/supervisor-helper.sh:5303(new functionauto_create_pr_for_task())Mechanism: Git heuristic Tier 2.5 enhancement (line 6134):
Action: When worker has commits on branch but no PR:
gh pr createwith commit summarylink_pr_to_task()(t232)complete:<PR_URL>→ normal PR lifecycle (review, merge, deploy)Result: Preserves worker output for review instead of retrying. Saves ~300s per occurrence.
3. Git Heuristic Coverage (Already Comprehensive)
Location:
.agents/scripts/supervisor-helper.sh:6093-6153(Tier 2.5)Current Coverage:
complete:<PR_URL>complete:<PR_URL>retry:work_in_progressResult: Catches all concrete evidence of work before expensive AI eval. Only truly ambiguous cases reach Tier 3.
Flow Comparison
Before (t247)
After (t247.1 + t247.2)
Impact
Testing
ghunavailableRelated
Task
Closes t247. Combines t247.1 (PR #987) and t247.2 (PR #988).