Add client scope role mappings #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carillonator
force-pushed
the
client-scope-role-mapping
branch
10 times, most recently
from
bce0808
to
f0b2860
Compare
carillonator
commented
Oct 11, 2024
carillonator
requested review from
ryshoooo and
marcospereirampj
as code owners
|
@ryshoooo @marcospereirampj any chance you could review this please? |
ryshoooo
reviewed
Oct 26, 2024
ryshoooo
reviewed
Oct 26, 2024
carillonator
force-pushed
the
client-scope-role-mapping
branch
2 times, most recently
from
b37f17a
to
033e750
Compare
carillonator
force-pushed
the
client-scope-role-mapping
branch
from
033e750
to
2dc1acc
Compare
|
@ryshoooo thanks for the review -- updated with all your suggestions. |
ryshoooo
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions to get/add/delete Client Scope role mappings. Note there are already unfortunately-named
get/assign/delete_client_roles_to_client_scopefunctions, which act on a Client's "dedicated" scope. I am open to adjusting the naming here, the keycloak terminology itself is confusing. My new names do not help the confusion, but are more accurate. I've improved the documentation on the existing ones, and cross-referenced the others to avoid confusing people.