Implemented a ClientFactory to obtain a new instance of a ChatGptClient #45
Conversation
| this.defaultOptions = defaultOptions; | ||
| } | ||
|
|
||
| public IChatGptClient CreateClient(Action<ChatGptOptions> setupAction) |
There was a problem hiding this comment.
The parameter should be nullable and optional, if I want to create a client with the default options and I don't need to change anything else. Moreover, an overload the accepts a ServiceProvider as argument is needed, to cover a scenario like this one:
It is necessary when I need to provide options that have external dependencies (for example, an Api Key that depends on the current user).
There was a problem hiding this comment.
Implemented the CreateClient method with 3 overloads: a parameterless version that uses the default options, plus two overloads that accept an Action<ChatGptOptions> or Action<IServiceProvider, ChatGptOptions>
| setupAction.Invoke(options); | ||
|
|
||
| services.AddMemoryCache(); | ||
| services.AddSingleton<IChatGptClientFactory, ChatGptClientFactory>( |
There was a problem hiding this comment.
Why are you using this method and not simply, after adding ChatGptOptions itself to the service collection, like in
services.AddSingleton<IChatGptClientFactory, ChatGptClientFactory>();
| /// <param name="services">The <see cref="IServiceCollection"/> to add services to.</param> | ||
| /// <param name="setupAction">The <see cref="Action{ChatGptOptions}"/> to configure the provided <see cref="ChatGptOptions"/>.</param> | ||
| /// <returns>A reference to this instance after the operation has completed.</returns> | ||
| public static IServiceCollection AddChatGptClientFactory(this IServiceCollection services, Action<ChatGptOptions> setupAction) |
There was a problem hiding this comment.
If I'm creating a factory, there is the case in which I don't want to directly provide an Action to setup ChatGtpOptions, so this parameter should be nullable and optional.
There was a problem hiding this comment.
Added now an AddChatGptClientFactory(this IServiceCollection services) that allows to customize later the client
|
@nicolaparo, sorry for the long delay. Do you mind updating your PR to the latest commit of the library and then requesting a review? Thanks |
Adding the
AddChatGptClientFactoryto add the ClientFactory.Remarks:
ChatGptServiceCollectionExtensions.ConfigureHttpClientfromprivatetointernalin order to be able to correctly configure the httpclient in the factoryCreateClientmethod.ChatGptOptionsfrom class torecordin order to support thedefaultOptionscloning usingwith { }. This way the changes to the options are applied to a separate copy of the object in theCreateClientmethod.