Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine comments in UpdateCacheAsync method #163

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Refine comments in UpdateCacheAsync method #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ChatGptNet/ChatGptClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,14 +392,14 @@ private async Task AddAssistantResponseAsync(Guid conversationId, IList<ChatGptM
private async Task UpdateCacheAsync(Guid conversationId, IEnumerable<ChatGptMessage> messages, CancellationToken cancellationToken = default)
{
// If the maximum number of messages has been reached, deletes the oldest ones.
// Note: system message does not count for message limit.
// Note: the system message does not count for message limit.
var conversation = messages.Where(m => m.Role != ChatGptRoles.System);

if (conversation.Count() > options.MessageLimit)
{
conversation = conversation.TakeLast(options.MessageLimit);

// If the first message was of role system, adds it back in.
// If the first message had the system role, adds it back in.
var firstMessage = messages.First();
if (firstMessage.Role == ChatGptRoles.System)
{
Expand Down
Loading