fix: object with hasOwnProperty key #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential runtime exception that could occur when JSON objects contain a property named hasOwnProperty. The code now uses Object.prototype.hasOwnProperty.call() instead of the unsafe instance method to safely check property existence.
Key Changes:
- Replaced all instances of
object.hasOwnProperty(key)withObject.prototype.hasOwnProperty.call(object, key)to safely handle objects withhasOwnPropertyas a key - Added test data including an object with
hasOwnPropertyproperty to validate the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Updated all hasOwnProperty checks to use safe Object.prototype.hasOwnProperty.call() pattern |
| src/index.spec.ts | Added test object with hasOwnProperty key to validate the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcolink
changed the title
Owner
|
Thanks for your contribution @BrianHuf |
marcolink
pushed a commit
that referenced
this pull request
Oct 28, 2025
## [1.2.5](v1.2.4...v1.2.5) (2025-10-28) ### Bug Fixes * object with hasOwnProperty key ([#15](#15)) ([93ad8e2](93ad8e2))
Owner
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid exception if JSON object happens to have a
hasOwnPropertykey