Skip to content

Commit

Permalink
Bug 1575720 [wpt PR 18604] - Make table's clientWidth/Height include …
Browse files Browse the repository at this point in the history
…its border sizes., a=testonly

Automatic update from web-platform-tests
Make table's clientWidth/Height include its border sizes.

Blink doesn't have table wrapper box currently
while Gecko has it,
so this CL tries to mimic the behavior that
clientWidth/Height refers to table wrapper box
which doesn't have borders applied to itself
and table grid box has the borders.

This CL adds table's border sizes
to clientWidth/Height
at |LayoutBox::PixelSnappedClientWidth/Height|.

As a result of this CL, table's clientWidth/Height
and offsetWidth/Height are equal now, respectively.

The corresponding csswg discussion is
w3c/csswg-drafts#4245.

Bug: 560528, 978019
Change-Id: I2693eaf38b882fe4a41f931ec1312ecf53352f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763510
Commit-Queue: Joonghun Park <pjh0718gmail.com>
Reviewed-by: Koji Ishii <kojiichromium.org>
Reviewed-by: Morten Stenshorne <mstenshochromium.org>
Reviewed-by: David Grogan <dgroganchromium.org>
Reviewed-by: Mason Freed <masonfreedchromium.org>
Cr-Commit-Position: refs/heads/master{#701557}

--

wpt-commits: 7bc2d379af8ead0a92387253540a6ee2915783a8
wpt-pr: 18604

UltraBlame original commit: 25fa8a9e18c8cbd88f88a6546a93991e358992db
  • Loading branch information
marco-c committed Oct 16, 2019
1 parent 5e1044e commit d4af632
Show file tree
Hide file tree
Showing 3 changed files with 950 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,320 @@
<
!
DOCTYPE
html
>
<
title
>
CSSOM
Test
:
Table
with
border
-
collapse
:
collapse
'
s
clientWidth
/
Height
<
/
title
>
<
link
rel
=
"
help
"
href
=
"
https
:
/
/
www
.
w3
.
org
/
TR
/
CSS2
/
tables
.
html
#
model
"
/
>
<
link
rel
=
"
help
"
href
=
"
https
:
/
/
www
.
w3
.
org
/
TR
/
CSS2
/
tables
.
html
#
collapsing
-
borders
"
/
>
<
link
rel
=
"
help
"
href
=
"
https
:
/
/
drafts
.
csswg
.
org
/
cssom
-
view
/
#
extension
-
to
-
the
-
element
-
interface
"
/
>
<
script
src
=
/
resources
/
testharness
.
js
>
<
/
script
>
<
script
src
=
/
resources
/
testharnessreport
.
js
>
<
/
script
>
<
style
>
table
{
border
-
collapse
:
collapse
;
}
td
{
border
:
8px
solid
#
faa
;
}
<
/
style
>
<
table
>
<
tbody
>
<
tr
>
<
td
>
a
<
/
td
>
<
td
>
b
<
/
td
>
<
/
tr
>
<
tr
>
<
td
>
c
<
/
td
>
<
td
>
d
<
/
td
>
<
/
tr
>
<
/
tbody
>
<
/
table
>
<
script
type
=
"
text
/
javascript
"
>
var
table
=
document
.
getElementsByTagName
(
'
table
'
)
[
0
]
;
test
(
function
(
)
{
assert_equals
(
table
.
clientWidth
table
.
offsetWidth
)
;
assert_equals
(
table
.
clientHeight
table
.
offsetHeight
)
;
}
"
Table
'
s
clientWidth
/
Height
and
OffsetWidth
/
Height
should
be
the
same
"
)
;
<
/
script
>
Loading

0 comments on commit d4af632

Please sign in to comment.